Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qosmic: init at 1.6.0 #95574

Merged
merged 1 commit into from
Aug 22, 2020
Merged

qosmic: init at 1.6.0 #95574

merged 1 commit into from
Aug 22, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Aug 16, 2020 •
edited
Loading

Motivation for this change

Pretty pictures

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 16, 2020
jtojnar
jtojnar reviewed Aug 16, 2020
View reviewed changes
@raboof raboof mentioned this pull request Aug 16, 2020
Merged
@raboof raboof force-pushed the nixpkgs-qosmic branch 3 times, most recently from c523f33 to 962f30f Compare August 16, 2020 19:07
@raboof raboof requested a review from jtojnar August 16, 2020 19:08
@raboof @jtojnar
qosmic: init at 1.6.0
0e725da 
Co-Authored-By: Jan Tojnar <[email protected]>
@raboof raboof requested a review from jtojnar August 17, 2020 06:43
@ryantm
Copy link
Member

ryantm commented Aug 22, 2020

Result of nixpkgs-review pr 95574 1

1 package built:
- qosmic

@ryantm ryantm merged commit b4e601b into NixOS:master Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raboof @ryantm @jtojnar