runInLinuxVM: apply Qemu's vCPU limit #386224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
pkgs.vmTools.runInLinuxVM
is used, e.g. bymake-disk-image.nix
and some tests. Its starts a Qemu instance but may fail on systems with >= 256 CPU cores because Qemu for now only supports 255 cores.Solution:
Limit number of virtual CPUs created by Qemu to 255.
Tested on a 256 core system.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-build ./pkgs/build-support/vm/test.nix
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.
@Mic92 @lheckemann @wolfgangwalther