Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adwaita-fonts: init at v48.2 #378641

Merged
merged 1 commit into from
Feb 6, 2025
Merged

adwaita-fonts: init at v48.2 #378641

merged 1 commit into from
Feb 6, 2025

Conversation

qxrein
Copy link
Member

@qxrein qxrein commented Feb 1, 2025

RESOLVES #378562

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Feb 1, 2025
Copy link
Member

@Gliczy Gliczy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this to pkgs/by-name.

Packages in pkgs/by-name doesn't need to be added to all-packages.nix and it's where new package should be made.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/data/fonts/adwaita-fonts/default.nix Outdated Show resolved Hide resolved
@github-actions github-actions bot added 10.rebuild-linux: 1 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 1, 2025
@arthsmn
Copy link
Member

arthsmn commented Feb 1, 2025

Please squash all the commits. Also, change the title to be init at instead of just init.

@qxrein qxrein changed the title adwaita-fonts: init v48.2 adwaita-fonts: init at v48.2 Feb 2, 2025
@qxrein qxrein requested review from arthsmn and Gliczy February 2, 2025 06:39
@arthsmn
Copy link
Member

arthsmn commented Feb 2, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 378641


x86_64-linux

✅ 1 package built:
  • adwaita-fonts

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 2, 2025
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits and drop the v prefix in the commit title.

@qxrein
Copy link
Member Author

qxrein commented Feb 6, 2025

its been 2 days

@drupol drupol merged commit 16b7830 into NixOS:master Feb 6, 2025
4 of 6 checks passed
@drupol
Copy link
Contributor

drupol commented Feb 6, 2025

Thanks for the gentle and kind reminder. It's merged, hope you're satisfied now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: adwaita-fonts
7 participants