-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adwaita-fonts: init at v48.2 #378641
adwaita-fonts: init at v48.2 #378641
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this to pkgs/by-name
.
Packages in pkgs/by-name
doesn't need to be added to all-packages.nix
and it's where new package should be made.
Please squash all the commits. Also, change the title to be |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash the commits and drop the v prefix in the commit title.
its been 2 days |
Thanks for the gentle and kind reminder. It's merged, hope you're satisfied now. |
RESOLVES #378562
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.