Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.{type-infer,dataprep-ml,diffenator2,ibis-framework}: relax dependencies #378636

Merged
merged 7 commits into from
Feb 1, 2025
Merged

python312Packages.{type-infer,dataprep-ml,diffenator2,ibis-framework}: relax dependencies #378636

merged 7 commits into from
Feb 1, 2025

Conversation

NickCao
Copy link
Member

@NickCao NickCao commented Feb 1, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from barinov274 February 1, 2025 21:11
@NickCao
Copy link
Member Author

NickCao commented Feb 1, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 378636

x86_64-linux

❌ 8 packages failed to build:
  • python313Packages.dataprep-ml
  • python313Packages.dataprep-ml.dist
  • python313Packages.ibis-framework
  • python313Packages.ibis-framework.dist
  • python313Packages.mindsdb-evaluator
  • python313Packages.mindsdb-evaluator.dist
  • python313Packages.type-infer
  • python313Packages.type-infer.dist
✅ 27 packages built:
  • fira-math
  • python312Packages.dataprep-ml
  • python312Packages.dataprep-ml.dist
  • python312Packages.diffenator2
  • python312Packages.diffenator2.dist
  • python312Packages.fontmake
  • python312Packages.fontmake.dist
  • python312Packages.gftools
  • python312Packages.gftools.dist
  • python312Packages.ibis-framework
  • python312Packages.ibis-framework.dist
  • python312Packages.mindsdb-evaluator
  • python312Packages.mindsdb-evaluator.dist
  • python312Packages.notobuilder
  • python312Packages.notobuilder.dist
  • python312Packages.type-infer
  • python312Packages.type-infer.dist
  • python313Packages.diffenator2
  • python313Packages.diffenator2.dist
  • python313Packages.fontmake
  • python313Packages.fontmake.dist
  • python313Packages.gftools
  • python313Packages.gftools.dist
  • python313Packages.notobuilder
  • python313Packages.notobuilder.dist
  • smc-chilanka
  • smc-manjari

@NickCao NickCao mentioned this pull request Feb 1, 2025
Closed
13 tasks
GaetanLepage
GaetanLepage approved these changes Feb 1, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@NickCao NickCao merged commit 0d24ab0 into NixOS:master Feb 1, 2025
25 of 27 checks passed
@NickCao NickCao deleted the relax branch February 1, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@mbalatsko mbalatsko Awaiting requested review from mbalatsko

@cpcloud cpcloud Awaiting requested review from cpcloud

@jopejoe1 jopejoe1 Awaiting requested review from jopejoe1

@barinov274 barinov274 Awaiting requested review from barinov274

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NickCao @GaetanLepage