Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apple-sdk: set dontCheckForBrokenSymlinks #376043

Merged

Conversation

ConnorBaker
Copy link
Contributor

@ConnorBaker ConnorBaker commented Jan 23, 2025

Followup for #370750.

Should fix https://hydra.nixos.org/build/286340056.

@reckenrode any ideas on whether this is intentional, or if undesirable, what the solution is?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 5001+ 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 23, 2025
@vcunat
Copy link
Member

vcunat commented Jan 23, 2025

stdenv still won't build for aarch64-darwin.

ERROR: noBrokenSymlinks: the symlink /nix/store/65411519w4c992fffnw9pj3agd4p3l75-clang-wrapper-19.1.6/resource-root/share points to a missing target /nix/store/w5hmg9ygb7qg64cy0sygaj1k0np9fi47-compiler-rt-19.1.6/share
ERROR: noBrokenSymlinks: found 1 dangling symlinks and 0 reflexive symlinks

@ConnorBaker ConnorBaker force-pushed the feat/stdenv-no-broken-symlinks-hook branch from f67ef76 to 9cdac5f Compare January 23, 2025 19:31
@ConnorBaker
Copy link
Contributor Author

stdenv still won't build for aarch64-darwin.

ERROR: noBrokenSymlinks: the symlink /nix/store/65411519w4c992fffnw9pj3agd4p3l75-clang-wrapper-19.1.6/resource-root/share points to a missing target /nix/store/w5hmg9ygb7qg64cy0sygaj1k0np9fi47-compiler-rt-19.1.6/share
ERROR: noBrokenSymlinks: found 1 dangling symlinks and 0 reflexive symlinks

That failure is tracked by #376202.

@emilazy
Copy link
Member

emilazy commented Jan 26, 2025

Should be obsoleted by #377168.

@vcunat vcunat merged commit 6edefd6 into NixOS:staging Jan 27, 2025
33 of 35 checks passed
@vcunat
Copy link
Member

vcunat commented Jan 27, 2025

I took this one for now, because it's very simple and we can have it now. I'd like to unblock progress with other stuff. @emilazy: you can revert this in your draft PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 5001+ 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants