Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

krita: switch to openexr_3 #375828

Merged
merged 1 commit into from
Jan 25, 2025
Merged

krita: switch to openexr_3 #375828

merged 1 commit into from
Jan 25, 2025

Conversation

autra
Copy link
Contributor

@autra autra commented Jan 22, 2025 •
edited
Loading

Things done

Part of #367406

openexr v2 is EOL and insecure.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@autra autra mentioned this pull request Jan 22, 2025
Draft
56 tasks
@autra
Copy link
Contributor Author

autra commented Jan 22, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 375828

x86_64-linux

✅ 2 packages built:
  • krita
  • krita-plugin-gmic

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 22, 2025
@nix-owners nix-owners bot requested review from sifmelcara, abbradar and nek0 January 22, 2025 13:26
@autra autra force-pushed the krita_to_openexr_3 branch from 04d8b14 to a1983a6 Compare January 22, 2025 13:46
@autra autra added the backport release-24.11 Backport PR automatically label Jan 22, 2025
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jan 23, 2025
@FliegendeWurst FliegendeWurst merged commit 56e244a into NixOS:master Jan 25, 2025
68 of 70 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 25, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jan 25, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sifmelcara sifmelcara sifmelcara approved these changes

@abbradar abbradar Awaiting requested review from abbradar

@nek0 nek0 Awaiting requested review from nek0

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@autra @sifmelcara @wegank @FliegendeWurst