nixos/mongodb: add support for mongodb-ce package #375587
Open
+77
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
niklaskorz
force-pushed
the
nixos-mongodb-ce
branch
from
a566391 to
93f696f
Compare
drupol
reviewed
Jan 21, 2025
github-actions
bot
added
10.rebuild-darwin: 0
niklaskorz
force-pushed
the
nixos-mongodb-ce
branch
3 times, most recently
from
f9a8396 to
ebc1c7f
Compare
…rt for mongodb-ce
niklaskorz
force-pushed
the
nixos-mongodb-ce
branch
from
ebc1c7f to
9e1806e
Compare
drupol
approved these changes
Jan 21, 2025
drupol
requested changes
Jan 21, 2025
| @@ -12,6 +12,7 @@ | |||
| nix-update, | |||
| gitMinimal, | |||
| pup, | |||
| nixosTests, | |||
There was a problem hiding this comment.
Don't use nixosTests for checking version, use versionCheckHook.
Example:
nixpkgs/pkgs/by-name/ty/typst/package.nix
Line 10 in 79ade21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues inside
services.mongodbcurrently making it incompatible with themongodb-cepackage. Namely, it now uses the mongosh package to configure the initial superuser instead of the legacy shell bundled in the other mongodb packages.I also refactored the mongodb tests to:
services.mongodbinstead of trying to start themongodbinary inside the testNote that test execution requires unfree packages to be allowed, e.g.
NIXPKGS_ALLOW_UNFREE=1 nix-build -A nixosTests.mongodb-ce, until NixOS/rfcs#185 is accepted.CC @drupol as maintainer of mongodb-ce
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.