-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alsa-ucm-conf: fix hardcoded FHS paths #371108
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/dell-xps-13-9320-microphone-not-working/40932/8 |
There seem to be a few Not sure if they can/should be replaced, though. |
Great, going to fix them too now. |
/bin/rm
and /bin/mkdir
9613a91
to
c18ebb2
Compare
@drupol re #371100 (comment) What happened there is that your PR contained commits from master that weren't in staging yet, and when you changed the merge base from master to staging a bot detects those commits and asks for a review of everyone who is a relevant owner for anything touched by any of those commits. It's a bit of a bug in the CI automation of nixpkgs if you ask me but it only goes wrong once every ~3mo, so for now people just seem to live with it :) The nixpkgs way to change base is to first rebase your new commits onto $(git merge-base upstream/{master,staging}), force push that, then change the PR target in github. Finally, if you wish, rebase your changes back on top of the latest commit of master or staging, if that makes you happy. |
It's not supposed to go wrong anymore. code-owners-v2 has fixed this for code-owner review requests and if it wasn't for the recent change from ofborg to GA for maintainer requests, it wouldn't happen for those cases either. So yes, it was a bug, but a very recent one, introduced yesterday, fixed today. |
Good to hear, although I'm surprised to hear "introduced yesterday" part because I've run into this problem myself, and been pinged when others did. Am I talking about something else? Pretty sure "changing the target branch of a github PR" has been a dangerous thing to do since I joined >2y ago. |
Feel free to also review this PR 😆 ! |
It is fairly safe since #347610. Worst case is some excessive labeling. |
I recreated #371100 here, hopefully it won't ping all the people this time.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.