Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 24.11] nixos/oci-containers: option to set the service name of a oci-ontainer #370887

Merged
merged 1 commit into from
Jan 4, 2025
Merged

[Backport 24.11] nixos/oci-containers: option to set the service name of a oci-ontainer #370887

merged 1 commit into from
Jan 4, 2025

Conversation

lucasew
Copy link
Contributor

@lucasew lucasew commented Jan 4, 2025 •
edited
Loading

  • nixos/oci-containers: option to set the service name of a oci-container

Backport of #370089

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lucasew lucasew changed the base branch from master to release-24.11 January 4, 2025 16:00
@github-actions github-actions bot added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: haskell 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: rust 6.topic: policy discussion 6.topic: hardware 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: testing Tooling for automated testing of packages and modules 6.topic: module system About "NixOS" module system internals 6.topic: flakes The experimental Nix feature 6.topic: lib The Nixpkgs function library 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: dotnet Language: .NET 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions and removed 6.topic: python 6.topic: haskell 8.has: documentation This PR adds or changes documentation 8.has: changelog 6.topic: rust 6.topic: policy discussion 6.topic: hardware 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: testing Tooling for automated testing of packages and modules 6.topic: module system About "NixOS" module system internals 6.topic: flakes The experimental Nix feature 6.topic: lib The Nixpkgs function library labels Jan 4, 2025
@github-actions github-actions bot removed 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: dotnet Language: .NET 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions labels Jan 4, 2025
@lucasew lucasew force-pushed the 20250104-backport-oci-container-service-name branch from d0fc2b8 to 6b580e7 Compare January 4, 2025 16:02
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 4, 2025
@lucasew lucasew requested a review from Gabriella439 January 4, 2025 17:11
@lucasew lucasew requested a review from GaetanLepage January 4, 2025 17:31
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 4, 2025
@GaetanLepage GaetanLepage merged commit 8f1fa8d into NixOS:release-24.11 Jan 4, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@Gabriella439 Gabriella439 Gabriella439 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucasew @Gabriella439 @GaetanLepage @wegank