nixos/zipline: init module #370878
Merged
nixos/zipline: init module #370878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
github-actions
bot
added
8.has: documentation
This comment was marked as outdated.
This comment was marked as outdated.
|
Tested the module on my server, works perfectly fine! No issues with it |
|
updated to v3.7.11 |
|
pkgs/by-name/zi/zipline/package.nix
Outdated
| YARN_ENABLE_TELEMETRY = "0"; | ||
|
|
||
| FFMPEG_BIN = lib.getExe ffmpeg; | ||
| PRISMA_SCHEMA_ENGINE_BINARY = lib.getExe' prisma-engines "schema-engine"; |
There was a problem hiding this comment.
Would be cool if we could dedupe those with the ones below somehow
There was a problem hiding this comment.
I moved them into an environment attrset which is used in both the configure phase and the wrapper script. Regarding your other review comment, escaping these values is probably not necessary right now, however in the future one might need to add more environment variables, so I figured it would be a good idea to add the escaping now, so we don't have to rely on environment to only contain already escaped values.
SuperSandro2000
approved these changes
Jan 13, 2025
h7x4
added
8.has: module (new)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #354786
https://zipline.diced.sh/
https://github.com/diced/zipline
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.