Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libmsquic: init at 2.4.7 #370390

Merged
merged 1 commit into from
Jan 7, 2025
Merged

libmsquic: init at 2.4.7 #370390

merged 1 commit into from
Jan 7, 2025

Conversation

SohamG
Copy link
Contributor

@SohamG SohamG commented Jan 2, 2025

Things done

admin

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@SohamG
Copy link
Contributor Author

SohamG commented Jan 2, 2025

Please let me know if I am expected to format with rfc-style or with classic

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 2, 2025
RossComputerGuy
RossComputerGuy requested changes Jan 3, 2025
View reviewed changes
Copy link
Member

@RossComputerGuy RossComputerGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please use the new rfc style. I've got some other nitpicks.

pkgs/by-name/li/libmsquic/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/li/libmsquic/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/li/libmsquic/package.nix Outdated Show resolved Hide resolved
@SohamG
Copy link
Contributor Author

SohamG commented Jan 3, 2025

Formatted with RFC-style and onboarded changes.

@RossComputerGuy
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370390

aarch64-linux

✅ 1 package built:
  • libmsquic

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 3, 2025
@RossComputerGuy
Copy link
Member

Please run nixfmt again, it looks like the formatting broke.

@SohamG
Copy link
Contributor Author

SohamG commented Jan 3, 2025

Done

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 4, 2025
@JohnRTitor
Copy link
Contributor

@ofborg build libmsquic

@SohamG
Copy link
Contributor Author

SohamG commented Jan 5, 2025

Im afraid Ofborg is stuck. It doesnt take 30mins to build this package, and the logs.ofborg link points to the default nginx page with a bad-domain-name cert.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370390

x86_64-linux

✅ 1 package built:
  • libmsquic

aarch64-linux

✅ 1 package built:
  • libmsquic

GaetanLepage
GaetanLepage approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 6, 2025
@RossComputerGuy RossComputerGuy merged commit 4831e8d into NixOS:master Jan 7, 2025
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnRTitor JohnRTitor JohnRTitor left review comments

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@RossComputerGuy RossComputerGuy RossComputerGuy approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: libmsquic
5 participants
@SohamG @RossComputerGuy @JohnRTitor @GaetanLepage @wegank