Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dell-command-configure: fix missing include in wrapper #368471

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

magneticflux-
Copy link
Contributor

@magneticflux- magneticflux- commented Dec 27, 2024

Also removes unused rec.

Fixes:

Running phase: unpackPhase
Running phase: patchPhase
lib.c: In function 'access_wrapper':
lib.c:13:16: error: implicit declaration of function 'access' [-Wimplicit-function-declaration]
   13 |         return access(fn, mode);
      |                ^~~~~~

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 27, 2024
Copy link
Contributor

@RyanGibb RyanGibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Any idea what caused this to start failing?

@magneticflux-
Copy link
Contributor Author

GCC update rearranged header internals so unistd.h isn't pulled in by stdio.h or string.h, I think? It only worked this long because of that coincidence, but it wasn't technically correct until now.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 29, 2024
@wegank wegank merged commit bceaf35 into NixOS:master Jan 3, 2025
51 of 52 checks passed
@magneticflux- magneticflux- deleted the dell-command-configure-fixes branch January 4, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants