Make ec2 tests a channel blocker #365623
Open
Make ec2 tests a channel blocker #365623
+4
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been broken for as long as I know
This is more accurate. People dismissed failures in the past in this test because of the name. We don't want that. The test is important! It tests that SSH works! Hopefully this helps with NixOS#340489 (comment)
Not needed anymore. no idea why this was here
This is to catch issues like NixOS#340489 (comment) We do not want to push NixOS updates that break SSH access on EC2 instances.
github-actions
bot
added
6.topic: nixos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to catch issues like #340489 (comment)
We do not want to push NixOS updates that break SSH access on EC2 instances.
I also took the liberty to clean up the tests a little bit. And remove a test that has been broken since forever.
If someone has a good idea how to fix the
ec2-configtest I'm all ears. Perhapssystem.includeBuilDependencies = true;?Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.