nixos-firewall-tool: misc improvements #365207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbdd0121
added
the
11.by: package-maintainer
duament
approved these changes
Dec 15, 2024
wegank
added
12.approved-by: package-maintainer
|
I came here to open an issue over a bunch of things that this seems to address. LGTM! |
Scrumplex
reviewed
Dec 28, 2024
writeShellApplication doesn't really fit the tool well (evident from builtin.readFile) and it actually generates duplicate shebang lines.
nbdd0121
force-pushed
the
nixos-firewall-tool
branch
from
9dd648e to
d57da57
Compare
wegank
removed
12.approvals: 1
Scrumplex
approved these changes
Dec 29, 2024
wegank
added
12.approvals: 2
fpletz
approved these changes
Dec 30, 2024
|
FWIW, this broke the installer tests because of the filesets bug; see #369459. We should really make sure filesets don‘t get used inside Nixpkgs in CI somehow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the nixos-firewall-tool script, and adds man page and shell completions for bash and fish.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.