Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rstudio: build as electron app, add darwin support #362637

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

rstudio: build as electron app, add darwin support #362637

wants to merge 2 commits into from
+279 −36

Conversation

TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Dec 7, 2024 •
edited
Loading

Makes updating the package easier, since the current latest version no longer supports the QT-based build.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 7, 2024
@TomaSajt TomaSajt force-pushed the rstudio__ branch 6 times, most recently from a3a560c to a826cb3 Compare December 8, 2024 01:21
@ofborg ofborg bot requested a review from ciil December 8, 2024 10:01
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 8, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 6.topic: R 10.rebuild-darwin: 1-10 labels Dec 8, 2024
@TomaSajt TomaSajt changed the title rstudio: build the electron app instead of the qt app rstudio: build as electron app, add darwin support Dec 8, 2024
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 8, 2024
@TomaSajt TomaSajt mentioned this pull request Dec 8, 2024
Closed
@TomaSajt TomaSajt force-pushed the rstudio__ branch 4 times, most recently from 988ac7e to dc2da12 Compare December 9, 2024 20:44
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 9, 2024
@TomaSajt TomaSajt force-pushed the rstudio__ branch 2 times, most recently from 90fc1f7 to 7e7cebb Compare December 9, 2024 22:18
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Dec 10, 2024
@TomaSajt
Copy link
Contributor Author

TomaSajt commented Jan 3, 2025

Electron is not cached ATM, so we need to wait for a bit to test it.

@TomaSajt TomaSajt mentioned this pull request Jan 3, 2025
Merged
13 tasks
@TomaSajt TomaSajt force-pushed the rstudio__ branch 2 times, most recently from 15be340 to 4a3bcd0 Compare January 3, 2025 23:37
@emilylange
Copy link
Member

Electron is not cached ATM, so we need to wait for a bit to test it.

Just as a fyi:

You can usually base your PR on nixos-unstable-small or even nixos-unstable, target master and not run into merge-conflicts.

In this case, for electron to be cached, you would use nixos-unstable.

You can also rebase onto nixos-unstable locally, keep the remote as is, iterate and do your tests or whatever, and then rollback locally to the original base again.

@TomaSajt TomaSajt force-pushed the rstudio__ branch 3 times, most recently from 78fee69 to 3ea6635 Compare January 14, 2025 23:22
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/missing-symbols-when-packaging-electron-based-app-with-native-deps/59402/6

@TomaSajt
Copy link
Contributor Author

TomaSajt commented Feb 2, 2025 •
edited
Loading

Another boost version (1.87), another breakage:
https://www.boost.io/doc/libs/latest/doc/html/boost_asio/history.html
the io_service alias no longer exists, will probably have to subsituted with io_context

For now, I'll just lock boost to v1.86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciil ciil Awaiting requested review from ciil

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: R 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomaSajt @emilylange @nixos-discourse