Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redwax-tool: 0.9.1 -> 0.9.7 #360341

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

redwax-tool: 0.9.1 -> 0.9.7 #360341

wants to merge 6 commits into from

Conversation

minfrin
Copy link

@minfrin minfrin commented Nov 30, 2024

Upgrade to redwax-tool v0.9.7.

Add libraries for nss, p11-kit, libical, ldns, libunbound.

Note: as yet untested, still learning :)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Nov 30, 2024
@FliegendeWurst FliegendeWurst changed the title Upgrade redwax-tool to v0.9.7. redwax-tool: 0.9.1 -> 0.9.7 Dec 12, 2024

src = fetchsvn {
url = "https://source.redwax.eu/svn/redwax/rt/redwax-tool/tags/redwax-tool-${version}/";
sha256 = "sha256-MWSB1AkkRS18UUHGq8EWv3OIXPSVHpmrdD5Eq1VdbkA=";
sha256 = "sha256-fill-me-in";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please get the right hash :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had no clue as to where the hash came from, it appears to be a hash of a directory?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hash is used as parameter to fetchsvn. It is computed by checking out the redwax source at a specific version and hashing all files.

You can get the right hash by putting in sha256 = lib.fakeHash;, running the build and then copying the hash from the error message.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to change this to the tarballs below https://archive.redwax.eu/dist/rt/ - this is the permanent home of every release, and you'll be relying on our SHA256 hashes / PGP signatures, rather than what svn gave you.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Try

src = fetchurl {
  url = "https://archive.redwax.eu/dist/rt/redwax-tool-${version}/redwax-tool-${version}.tar.gz";
  hash = "sha256-GYxThKyvgeyQ1ksfRrqvDUC+8j/0WgskMgz2/4qN1R4=";
};

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been made so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants