Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opendht: 3.2.0 -> 3.2.0-unstable-2024-11-06 #356718

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

linsui
Copy link
Contributor

@linsui linsui commented Nov 17, 2024

#317263

Fix build with enableProxyServerAndClient enabled.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pbsds
Copy link
Member

pbsds commented Jan 17, 2025

@pbsbot
Copy link

pbsbot commented Jan 17, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 356718


x86_64-linux

✅ 5 packages built:
  • jami
  • opendht
  • opendht.dev
  • opendht.lib
  • opendht.man

@pbsds
Copy link
Member

pbsds commented Jan 17, 2025

It seems jami builds on hydra despite using that option:

opendht-jami =
(opendht.overrideAttrs {
src = fetchFromGitHub {
owner = "savoirfairelinux";
repo = "opendht";
rev = "074e05cc3254d5d73b0d96ee772a6e01bb3113e5";
hash = "sha256-WuaURlC7eDDxvnM3YuyU9CNrwnE4WBQUIEw3z/0zjN8=";
};
}).override
{
enableProxyServerAndClient = true;
enablePushNotifications = true;
};

Will that override keep working considering there is now a change of buildinputs?

@linsui
Copy link
Contributor Author

linsui commented Jan 17, 2025

It still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants