curl: display proper error message when encountering not trusted certificate #351920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperSandro2000
changed the title
SuperSandro2000
force-pushed
the
curl-cert-not-trusted
branch
from
1cdc478 to
c795a7e
Compare
ofborg
bot
added
the
2.status: merge conflict
lf-
approved these changes
Jan 9, 2025
wegank
added
the
12.approvals: 1
…ificate Right now the error message would be: curl: (35) OpenSSL/3.3.2: error:80000002:system library::No such file or directory Before it was: curl: (35) OpenSSL/3.0.8: error:16000069:STORE routines::unregistered scheme see curl/curl#10702
SuperSandro2000
force-pushed
the
curl-cert-not-trusted
branch
from
c795a7e to
ffbd9a7
Compare
ofborg
bot
removed
the
2.status: merge conflict
wegank
removed
the
12.approvals: 1
lf-
reviewed
Jan 25, 2025
| @@ -163,7 +163,7 @@ stdenv.mkDerivation (finalAttrs: { | |||
| "--without-ca-path" | |||
| ] ++ lib.optionals (!gnutlsSupport && !opensslSupport && !wolfsslSupport && !rustlsSupport) [ | |||
| "--without-ssl" | |||
| ] ++ lib.optionals (rustlsSupport && !stdenv.hostPlatform.isDarwin) [ | |||
| ] ++ lib.optionals ((opensslSupport || rustlsSupport) && !stdenv.hostPlatform.isDarwin) [ | |||
There was a problem hiding this comment.
may still not fix the problem on Darwin; unsure the lineage of this code
There was a problem hiding this comment.
I can't test darwin at the moment.
|
I just retested this locally and at least for me this issue is now fixed. I am not sure why which change exactly fixed it though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the error message would be:
curl: (35) OpenSSL/3.3.2: error:80000002:system library::No such file or directory
Before it was:
curl: (35) OpenSSL/3.0.8: error:16000069:STORE routines::unregistered scheme
see curl/curl#10702
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.