Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httpdirfs: 1.2.5 -> 1.2.6 #351506

Merged
merged 1 commit into from
Oct 28, 2024
Merged

httpdirfs: 1.2.5 -> 1.2.6 #351506

merged 1 commit into from
Oct 28, 2024

Conversation

anthonyroussel
Copy link
Member

@anthonyroussel anthonyroussel commented Oct 26, 2024 •
edited
Loading

fangfufu/httpdirfs@1.2.5...1.2.6

Note for reviewers: MacOS support has been removed upstream with 1.2.6 release.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@anthonyroussel anthonyroussel force-pushed the update/httpdirfs branch 2 times, most recently from 130ae05 to 486d802 Compare October 26, 2024 21:51
@ofborg ofborg bot requested review from sbruder and schnusch October 27, 2024 00:56
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 27, 2024
@Artturin
Copy link
Member

Note for reviewers: MacOS support has been removed upstream with 1.2.6 release.

Intentionally or accidentally? Linking a issue/pr/commit in the commit msg would be good

@anthonyroussel
Copy link
Member Author

anthonyroussel commented Oct 27, 2024 •
edited
Loading

Intentionally or accidentally? Linking a issue/pr/commit in the commit msg would be good

@Artturin Support for other operating systems has been intentionally removed upstream:

I don't have the resources to test out compilation for Linux distributions
other than Debian. I also do not have the resources to test out compilation for
FreeBSD or macOS. Thereforce I have removed the instruction on how to compile
for these operating systems in the README for now. Please feel free to send me a
pull request to add them back in.

See fangfufu/httpdirfs@1.2.5...1.2.6 and https://github.com/fangfufu/httpdirfs?tab=readme-ov-file#other-operating-systems

I'll add this to the commit message (EDIT: Done)

@anthonyroussel
httpdirfs: 1.2.5 -> 1.2.6
33e6512 
Changelog: fangfufu/httpdirfs@1.2.5...1.2.6

Unfortunately, MacOS support has been removed intentionally upstream with this release:

> I don't have the resources to test out compilation for Linux distributions
> other than Debian. I also do not have the resources to test out compilation for
> FreeBSD or macOS. Thereforce I have removed the instruction on how to compile
> for these operating systems in the README for now. Please feel free to send me a
> pull request to add them back in.

See https://github.com/fangfufu/httpdirfs?tab=readme-ov-file#other-operating-systems
@Artturin Artturin merged commit ff469b5 into NixOS:master Oct 28, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbruder sbruder Awaiting requested review from sbruder

@schnusch schnusch Awaiting requested review from schnusch

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthonyroussel @Artturin