Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtorrent-rasterbar-1_2_x: 1.2.11 -> 1.2.19 #351401

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

sergv
Copy link
Contributor

@sergv sergv commented Oct 26, 2024

I noticed that tribler wants libtorrent==1.2.19 (https://github.com/Tribler/tribler/blob/main/requirements.txt) so decided to update even though it seems to work with the current version.

Changelog: https://github.com/arvidn/libtorrent/blob/v1.2.19/ChangeLog.

The build instructions are since the library now depends on boost-build and still uses AFAIU mostly deprecated as of now Python’s setup.py. It's because of setup.py I've added PYTHON_INSTALL_PARAMS so that it will install python module in a way that Python 3.10+ can find and use. I don't really know what I'm doing here but if I don't adjust PYTHON_INSTALL_PARAMS then setup.py will install module as a Python egg which Python 3.10 cannot load. If someone more knowledgeable about Python packaging can review this that would be much appreciated.

The setup.py will call Boost's b2 build system and by default it will look for static libboost_system, 'libboos_python3.11, libcrypto, and libssl. That can be changed to shared but on my machine the resulting Python .so` module gets built with undefined symbols and cannot be loaded so static default seems like the best option.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@sergv
Copy link
Contributor Author

sergv commented Oct 28, 2024

@xvapx, @mkg20001 as nixpkgs maintainers of tribler, if you please could review update of libtorrent-rasterbar used by tribler it would be very useful, thanks.

@sergv
Copy link
Contributor Author

sergv commented Nov 9, 2024

Bump please

Update build for newer build system that depends on boost-build and
still uses AFAIU mostly deprecated as of now Python’s setup.py
@sergv sergv force-pushed the update-libtorrent-rasterbar-1_2 branch from 4d2beff to 0f46acc Compare November 10, 2024 12:30
@mkg20001
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 351401


x86_64-linux

✅ 4 packages built:
  • libtorrent-rasterbar-1_2_x
  • libtorrent-rasterbar-1_2_x.dev
  • libtorrent-rasterbar-1_2_x.python
  • tribler

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 10, 2024
@FliegendeWurst FliegendeWurst force-pushed the update-libtorrent-rasterbar-1_2 branch from 819a65f to 0f46acc Compare December 16, 2024 06:02
@FliegendeWurst FliegendeWurst merged commit dd1a79b into NixOS:master Dec 18, 2024
52 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants