libtorrent-rasterbar-1_2_x: 1.2.11 -> 1.2.19 #351401
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
tribler
wantslibtorrent==1.2.19
(https://github.com/Tribler/tribler/blob/main/requirements.txt) so decided to update even though it seems to work with the current version.Changelog: https://github.com/arvidn/libtorrent/blob/v1.2.19/ChangeLog.
The build instructions are since the library now depends on boost-build and still uses AFAIU mostly deprecated as of now Python’s
setup.py
. It's because ofsetup.py
I've addedPYTHON_INSTALL_PARAMS
so that it will install python module in a way that Python 3.10+ can find and use. I don't really know what I'm doing here but if I don't adjustPYTHON_INSTALL_PARAMS
thensetup.py
will install module as a Python egg which Python 3.10 cannot load. If someone more knowledgeable about Python packaging can review this that would be much appreciated.The
setup.py
will call Boost'sb2
build system and by default it will look for staticlibboost_system
, 'libboos_python3.11,
libcrypto, and
libssl. That can be changed to shared but on my machine the resulting Python
.so` module gets built with undefined symbols and cannot be loaded so static default seems like the best option.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.