Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.05] virtualbox: 7.0.18 -> 7.0.22 #351261

Merged
merged 3 commits into from
Dec 11, 2024
Merged

[24.05] virtualbox: 7.0.18 -> 7.0.22 #351261

merged 3 commits into from
Dec 11, 2024

Conversation

LeSuisse
Copy link
Contributor

@LeSuisse LeSuisse commented Oct 25, 2024 •
edited
Loading

Cherry-picks of #350707, #338117 and #330796

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@LeSuisse LeSuisse added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Oct 25, 2024
@LeSuisse LeSuisse marked this pull request as ready for review October 25, 2024 19:58
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Oct 25, 2024
@FriedrichAltheide FriedrichAltheide added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Oct 26, 2024
@bjornfor
Copy link
Contributor

Result of nixpkgs-review pr 351261 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • linuxKernel.packages.linux_5_4_hardened.virtualbox
  • linuxKernel.packages.linux_5_4_hardened.virtualboxGuestAdditions
  • linuxPackages_5_4_hardened.virtualbox
  • linuxPackages_5_4_hardened.virtualboxGuestAdditions
7 packages failed to build:
  • linuxPackages_5_15_hardened.virtualbox (linuxKernel.packages.linux_5_15_hardened.virtualbox)
  • linuxPackages_5_15_hardened.virtualboxGuestAdditions (linuxKernel.packages.linux_5_15_hardened.virtualboxGuestAdditions)
  • linuxPackages_6_1_hardened.virtualbox (linuxKernel.packages.linux_6_1_hardened.virtualbox)
  • linuxPackages_6_1_hardened.virtualboxGuestAdditions (linuxKernel.packages.linux_6_1_hardened.virtualboxGuestAdditions)
  • linuxPackages_hardened.virtualbox (linuxPackages_6_6_hardened.virtualbox)
  • linuxPackages_hardened.virtualboxGuestAdditions (linuxPackages_6_6_hardened.virtualboxGuestAdditions)
  • virtualboxKvm
41 packages built:
  • linuxKernel.packages.linux_4_19.virtualbox
  • linuxKernel.packages.linux_4_19.virtualboxGuestAdditions
  • linuxPackages_4_19_hardened.virtualbox (linuxKernel.packages.linux_4_19_hardened.virtualbox)
  • linuxPackages_4_19_hardened.virtualboxGuestAdditions (linuxKernel.packages.linux_4_19_hardened.virtualboxGuestAdditions)
  • linuxKernel.packages.linux_5_10.virtualbox
  • linuxKernel.packages.linux_5_10.virtualboxGuestAdditions
  • linuxPackages_5_10_hardened.virtualbox (linuxKernel.packages.linux_5_10_hardened.virtualbox)
  • linuxPackages_5_10_hardened.virtualboxGuestAdditions (linuxKernel.packages.linux_5_10_hardened.virtualboxGuestAdditions)
  • linuxKernel.packages.linux_5_15.virtualbox
  • linuxKernel.packages.linux_5_15.virtualboxGuestAdditions
  • linuxKernel.packages.linux_5_4.virtualbox
  • linuxKernel.packages.linux_5_4.virtualboxGuestAdditions
  • linuxKernel.packages.linux_6_1.virtualbox
  • linuxKernel.packages.linux_6_1.virtualboxGuestAdditions
  • linuxKernel.packages.linux_6_10.virtualbox
  • linuxKernel.packages.linux_6_10.virtualboxGuestAdditions
  • linuxPackages_latest.virtualbox (linuxKernel.packages.linux_6_11.virtualbox)
  • linuxPackages_latest.virtualboxGuestAdditions (linuxKernel.packages.linux_6_11.virtualboxGuestAdditions)
  • linuxPackages.virtualbox (linuxKernel.packages.linux_6_6.virtualbox)
  • linuxPackages.virtualboxGuestAdditions (linuxKernel.packages.linux_6_6.virtualboxGuestAdditions)
  • linuxPackages_latest-libre.virtualbox (linuxKernel.packages.linux_latest_libre.virtualbox)
  • linuxPackages_latest-libre.virtualboxGuestAdditions (linuxKernel.packages.linux_latest_libre.virtualboxGuestAdditions)
  • linuxPackages-libre.virtualbox (linuxKernel.packages.linux_libre.virtualbox)
  • linuxPackages-libre.virtualboxGuestAdditions (linuxKernel.packages.linux_libre.virtualboxGuestAdditions)
  • linuxPackages_lqx.virtualbox (linuxKernel.packages.linux_lqx.virtualbox)
  • linuxPackages_lqx.virtualboxGuestAdditions (linuxKernel.packages.linux_lqx.virtualboxGuestAdditions)
  • linuxPackages_xanmod.virtualbox (linuxKernel.packages.linux_xanmod.virtualbox)
  • linuxPackages_xanmod.virtualboxGuestAdditions (linuxKernel.packages.linux_xanmod.virtualboxGuestAdditions)
  • linuxPackages_xanmod_latest.virtualbox (linuxKernel.packages.linux_xanmod_latest.virtualbox ,linuxPackages_xanmod_stable.virtualbox)
  • linuxPackages_xanmod_latest.virtualboxGuestAdditions (linuxKernel.packages.linux_xanmod_latest.virtualboxGuestAdditions ,linuxPackages_xanmod_stable.virtualboxGuestAdditions)
  • linuxPackages_zen.virtualbox (linuxKernel.packages.linux_zen.virtualbox)
  • linuxPackages_zen.virtualboxGuestAdditions (linuxKernel.packages.linux_zen.virtualboxGuestAdditions)
  • virtualbox
  • virtualbox.modsrc
  • virtualboxExtpack
  • virtualboxHardened
  • virtualboxHardened.modsrc
  • virtualboxHeadless
  • virtualboxHeadless.modsrc
  • virtualboxWithExtpack
  • virtualboxWithExtpack.modsrc

@bjornfor
Copy link
Contributor

Result of nixpkgs-review pr 351261 run on x86_64-linux 1
4 packages marked as broken and skipped:

7 packages failed to build:

* linuxPackages_5_15_hardened.virtualbox (linuxKernel.packages.linux_5_15_hardened.virtualbox)

* linuxPackages_5_15_hardened.virtualboxGuestAdditions (linuxKernel.packages.linux_5_15_hardened.virtualboxGuestAdditions)

* linuxPackages_6_1_hardened.virtualbox (linuxKernel.packages.linux_6_1_hardened.virtualbox)

* linuxPackages_6_1_hardened.virtualboxGuestAdditions (linuxKernel.packages.linux_6_1_hardened.virtualboxGuestAdditions)

* linuxPackages_hardened.virtualbox (linuxPackages_6_6_hardened.virtualbox)

* linuxPackages_hardened.virtualboxGuestAdditions (linuxPackages_6_6_hardened.virtualboxGuestAdditions)

The above are already broken.

* virtualboxKvm

Regression!

$ nix-build -A virtualboxKvm

these 2 derivations will be built:
  /nix/store/rzgjh2hfqw3w1i2xlfbq77mbizlhzdji-virtualbox-7.0.22-kvm-dev-20240828.patch.drv
  /nix/store/3330f3ccsy63pphadn40g3f2djdawblg-virtualbox-7.0.22.drv
building '/nix/store/rzgjh2hfqw3w1i2xlfbq77mbizlhzdji-virtualbox-7.0.22-kvm-dev-20240828.patch.drv'...

trying https://github.com/cyberus-technology/virtualbox-kvm/releases/download/dev-20240828/kvm-backend-7.0.22-dev-20240828.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     9    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (56) The requested URL returned error: 404
error: cannot download virtualbox-7.0.22-kvm-dev-20240828.patch from any mirror
error: builder for '/nix/store/rzgjh2hfqw3w1i2xlfbq77mbizlhzdji-virtualbox-7.0.22-kvm-dev-20240828.patch.drv' failed with exit code 1;

@LeSuisse
Copy link
Contributor Author

Yes the failure of virtualboxKvm is expected according to the discussion in #350707

@bjornfor bjornfor mentioned this pull request Oct 28, 2024
Merged
13 tasks
risicle
risicle approved these changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review reveals no new failures, nixos x86_64

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 4, 2024
@wolfgangwalther wolfgangwalther merged commit 213ba67 into NixOS:release-24.05 Dec 11, 2024
37 of 43 checks passed
@LeSuisse LeSuisse deleted the virtualbox-7.0.22-24.05 branch December 11, 2024 22:10
@bjornfor bjornfor mentioned this pull request Dec 27, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle approved these changes

@FriedrichAltheide FriedrichAltheide FriedrichAltheide approved these changes

@svanderburg svanderburg Awaiting requested review from svanderburg

@blitz blitz Awaiting requested review from blitz

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@LeSuisse @bjornfor @risicle @FriedrichAltheide @wolfgangwalther @wegank @parthy