Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slint-lsp: 1.5.1 -> 1.8.0 #351029

Merged
merged 1 commit into from
Oct 26, 2024
Merged

slint-lsp: 1.5.1 -> 1.8.0 #351029

merged 1 commit into from
Oct 26, 2024

Conversation

xgroleau
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Tested the build and briefly the LSP

Add a 👍 reaction to pull requests you find important.

@xgroleau xgroleau changed the title slint-lsp: 1.5.0 -> 1.5.1 slint-lsp: 1.5.1 -> 1.8.0 Oct 24, 2024
@xgroleau xgroleau force-pushed the chore/update-slint-lsp branch from d464415 to e154e42 Compare October 24, 2024 21:25
@xgroleau xgroleau mentioned this pull request Oct 24, 2024
Closed
1 task
PaulDance
PaulDance approved these changes Oct 25, 2024
View reviewed changes
Copy link

@PaulDance PaulDance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

(although I have absolutely no say in this whatsoever 🤭)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4746

@Scrumplex
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 351029

x86_64-linux

✅ 1 package built:
  • slint-lsp

Scrumplex
Scrumplex reviewed Oct 26, 2024
View reviewed changes
Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs. Tested by formatting a .slint file.

pkgs/development/tools/misc/slint-lsp/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/misc/slint-lsp/default.nix Show resolved Hide resolved
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 26, 2024
@xgroleau xgroleau force-pushed the chore/update-slint-lsp branch 4 times, most recently from 8f2dc6e to 3b16164 Compare October 26, 2024 15:45
@xgroleau
Copy link
Member Author

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@xgroleau merge not permitted (#305350):
pkgs/top-level/all-packages.nix is not in pkgs/by-name/

@xgroleau
Copy link
Member Author

xgroleau commented Oct 26, 2024 •
edited
Loading

Ahh it's only for pacakge edit only, which makes total sense. Fair enough, that will still allow for future PR's

@xgroleau xgroleau force-pushed the chore/update-slint-lsp branch from 6470c9b to 0fd68a3 Compare October 26, 2024 16:17
@Scrumplex Scrumplex merged commit e041d36 into NixOS:master Oct 26, 2024
10 of 11 checks passed
@PaulDance
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scrumplex Scrumplex Scrumplex approved these changes

@PaulDance PaulDance PaulDance approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xgroleau @nixos-discourse @Scrumplex @PaulDance @wegank