Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liblsl and python3.pkgs.pylsl: init at 1.16.2 #350286

Merged
merged 3 commits into from
Oct 29, 2024
Merged

liblsl and python3.pkgs.pylsl: init at 1.16.2 #350286

merged 3 commits into from
Oct 29, 2024

Conversation

abcsds
Copy link
Contributor

@abcsds abcsds commented Oct 21, 2024

Things done

  • liblsl: init at 1.16.2
  • python3.pkgs.pylsl: init at 1.16.2
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from natsukium October 21, 2024 16:56
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Oct 21, 2024
@abcsds abcsds force-pushed the liblsl branch 3 times, most recently from adb388a to 8cf373b Compare October 26, 2024 15:21
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Oct 26, 2024
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Oct 26, 2024
@mkg20001
Copy link
Member

mkg20001 commented Oct 26, 2024 •
edited
Loading

Maintainer list change must be seperate commit titeled maintainers: add abcsds

abcsds and others added 3 commits October 28, 2024 16:55
@abcsds
liblsl: init at 1.16.2
5ba0dd2
@abcsds
maintainers: add abcsds
4832a5a
@abcsds @mkg20001
python3.pkgs.pylsl: init at 1.16.2
cc61a44 
Update pkgs/development/python-modules/pylsl/default.nix

Co-authored-by: Maciej Krüger <[email protected]>
@mkg20001 mkg20001 merged commit fc920a2 into NixOS:master Oct 29, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkg20001 mkg20001 mkg20001 left review comments

@natsukium natsukium Awaiting requested review from natsukium

Assignees
No one assigned
Labels
6.topic: python 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abcsds @mkg20001 @NixOSInfra