cvs: adopt and modernize #347762
cvs: adopt and modernize #347762
Conversation
AndersonTorres
force-pushed
the
adopt-cvs
branch
from
8bd531b to
78efd2c
Compare
|
@joshuakb2 can you please test this PR? |
|
@AndersonTorres sure, I'll let you know when I've tested it. |
|
@AndersonTorres yes, this cvs build is working for me. It does not try to use |
|
@AndersonTorres since the cvs binary is now built with a direct reference to the SSH executable, do you think the ssh package |
ofborg
bot
added
11.by: package-maintainer
AndersonTorres
force-pushed
the
adopt-cvs
branch
from
78efd2c to
1ef5e6c
Compare
|
I don't think it matters so much. The current method for customization has some annoying pitfalls; e.g. optional parameters can possibly clash with existing or future packages - https://github.com/NixOS/nixpkgs/pull/342692/files#r1785284171 Besides, I am waiting Atemu's experiments at #312432 before trying anything too savage in terms of customization. |
AndersonTorres
force-pushed
the
adopt-cvs
branch
from
1ef5e6c to
13622f7
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2051 |
AndersonTorres
force-pushed
the
adopt-cvs
branch
from
13622f7 to
3bb6170
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4809 |
wegank
added
the
2.status: merge conflict
AndersonTorres
force-pushed
the
adopt-cvs
branch
from
3bb6170 to
3a9c249
Compare
ofborg
bot
removed
the
2.status: merge conflict
- hammer - nixfmt-rfc-style - finalAttrs - no nested with - meta.mainProgram
This removes that uncanny preConfigure.
Co-authored-by: Joshua baker <[email protected]>
AndersonTorres
force-pushed
the
adopt-cvs
branch
from
3a9c249 to
eaaddd4
Compare
|
Closing since I no longer have time to deal with this. |
github-actions
bot
added
10.rebuild-darwin: 101-500
10.rebuild-linux: 101-500
and removed
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
Besides migrating to by-name and reformatting, it also picks the patches from their pristine locations.
Since at least the xz-incident we should strive to use pristine sources whenever possible.
Closes #347374 (hopefully)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.