-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Searxng rework #346777
Draft
SuperSandro2000
wants to merge
10
commits into
NixOS:master
Choose a base branch
from
SuperSandro2000:searxng-rework
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Searxng rework #346777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: module (update)
This PR changes an existing module in `nixos/`
labels
Oct 6, 2024
13 tasks
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
Oct 6, 2024
999eagle
reviewed
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally looks really good, the explicit nginx configuration is very nice! just a few suggestions on improving this (and of course excluding the changes from the general nginx/uwsgi rework)
SuperSandro2000
force-pushed
the
searxng-rework
branch
4 times, most recently
from
November 18, 2024 12:52
942edf2
to
d629ead
Compare
wegank
added
the
2.status: merge conflict
This PR has merge conflicts with the target branch
label
Dec 10, 2024
SuperSandro2000
force-pushed
the
searxng-rework
branch
from
December 11, 2024 00:10
cc6a5f3
to
eb490fc
Compare
…inx with uwsgi over a socket
SuperSandro2000
force-pushed
the
searxng-rework
branch
from
December 11, 2024 00:12
eb490fc
to
1547082
Compare
ofborg
bot
added
10.rebuild-darwin: 1
and removed
2.status: merge conflict
This PR has merge conflicts with the target branch
labels
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: module (update)
This PR changes an existing module in `nixos/`
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discovering that I had missed adding the uwsgi_params to my nginx config I thought we need an option to add a working nginx config automatically.
While I was at it, I also gave the module a spring clean.
Requires #346776
fyi @999eagle
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.