Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searxng rework #346777

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 6, 2024

After discovering that I had missed adding the uwsgi_params to my nginx config I thought we need an option to add a working nginx config automatically.

While I was at it, I also gave the module a spring clean.

Requires #346776

fyi @999eagle

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 6, 2024
Copy link
Contributor

@999eagle 999eagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks really good, the explicit nginx configuration is very nice! just a few suggestions on improving this (and of course excluding the changes from the general nginx/uwsgi rework)

nixos/modules/services/networking/searx.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/searx.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/searx.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/searx.nix Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 force-pushed the searxng-rework branch 4 times, most recently from 942edf2 to d629ead Compare November 18, 2024 12:52
@SuperSandro2000 SuperSandro2000 added the backport release-24.11 Backport PR automatically label Nov 18, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 10, 2024
@SuperSandro2000 SuperSandro2000 removed the backport release-24.11 Backport PR automatically label Dec 11, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 1 and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants