Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet: 9.0.0-preview.7 -> 9.0.0-rc.1 #342299

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

corngood
Copy link
Contributor

@corngood corngood commented Sep 16, 2024

Description of changes

Cc: @NixOS/dotnet

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: dotnet Language: .NET label Sep 16, 2024
@corngood
Copy link
Contributor Author

Result of nixpkgs-review pr 342299 run on x86_64-linux 1

10 packages built:
  • dotnetCorePackages.aspnetcore_9_0
  • dotnetCorePackages.dotnet_9.aspnetcore
  • dotnetCorePackages.dotnet_9.runtime
  • dotnetCorePackages.dotnet_9.sdk
  • dotnetCorePackages.dotnet_9.sdk.artifacts
  • dotnetCorePackages.dotnet_9.sdk.packages
  • dotnetCorePackages.dotnet_9.vmr
  • dotnetCorePackages.runtime_9_0
  • dotnetCorePackages.sdk_9_0
  • roslyn-ls

1 similar comment
@GGG-KILLER
Copy link
Contributor

Result of nixpkgs-review pr 342299 run on x86_64-linux 1

10 packages built:
  • dotnetCorePackages.aspnetcore_9_0
  • dotnetCorePackages.dotnet_9.aspnetcore
  • dotnetCorePackages.dotnet_9.runtime
  • dotnetCorePackages.dotnet_9.sdk
  • dotnetCorePackages.dotnet_9.sdk.artifacts
  • dotnetCorePackages.dotnet_9.sdk.packages
  • dotnetCorePackages.dotnet_9.vmr
  • dotnetCorePackages.runtime_9_0
  • dotnetCorePackages.sdk_9_0
  • roslyn-ls

@GGG-KILLER GGG-KILLER added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 16, 2024
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 16, 2024
@corngood
Copy link
Contributor Author

corngood commented Sep 16, 2024

Result of nixpkgs-review run on aarch64-darwin 1

10 packages built:
  • dotnetCorePackages.aspnetcore_9_0
  • dotnetCorePackages.dotnet_9.aspnetcore
  • dotnetCorePackages.dotnet_9.runtime
  • dotnetCorePackages.dotnet_9.sdk
  • dotnetCorePackages.dotnet_9.sdk.artifacts
  • dotnetCorePackages.dotnet_9.sdk.packages
  • dotnetCorePackages.dotnet_9.vmr
  • dotnetCorePackages.runtime_9_0
  • dotnetCorePackages.sdk_9_0
  • roslyn-ls

*note: roslyn-ls fails to build in the sandbox (NixOS/nix#4119). everything else works

@corngood corngood merged commit 310ee00 into NixOS:master Sep 16, 2024
59 checks passed
@corngood corngood deleted the dotnet-upgrade branch September 16, 2024 15:30
@GGG-KILLER
Copy link
Contributor

GGG-KILLER commented Sep 27, 2024

@corngood I've been running into the following on a project of mine after this update, have you run into the same?

[ggg@sora:~/Git/GGG-KILLER/Loretta]$ dotnet restore -v diag
/nix/store/pdjbc8jfjp6y95i23lnd87wn0s4ddprv-dotnet-core-combined/sdk/9.0.100-preview.7.24407.12/MSBuild.dll -nologo -distributedlogger:Microsoft.DotNet.Tools.MSBuild.MSBuildLogger,/nix/store/1k6xg0qsjm49z35zdk94q2rfrgr2hlma-dotnet-sdk-9.0.100-rc.1.24452.12/sdk/9.0.100-rc.1.24452.12/dotnet.dll*Microsoft.DotNet.Tools.MSBuild.MSBuildForwardingLogger,/nix/store/1k6xg0qsjm49z35zdk94q2rfrgr2hlma-dotnet-sdk-9.0.100-rc.1.24452.12/sdk/9.0.100-rc.1.24452.12/dotnet.dll -maxcpucount -target:Restore -tlp:default=auto -verbosity:m -verbosity:diag ./Loretta.sln

Restore failed in 4.6s

I've tested using a Dev Container and it work there, so it seems to be something on our NixOS version.

Update: got fixed after updating my flake for some reason.

@GGG-KILLER GGG-KILLER mentioned this pull request Oct 12, 2024
13 tasks
@corngood
Copy link
Contributor Author

@GGG-KILLER that doesn't seem familiar. Any idea how I could reproduce it? Have you tried cleaning your working tree and/or ~/.nuget?

@GGG-KILLER
Copy link
Contributor

Okay, nevermind, it seems after updating my flake somehow fixed it @corngood. Ignore what I said.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: dotnet Language: .NET 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants