-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: nixos/xen: init guest-agent module #341129
base: master
Are you sure you want to change the base?
Conversation
We now have a module that enables the upstream Xen Guest Agent, so we shouldn't tell users Citrix's XenServer tools are the main Xen guest utilities. Signed-off-by: Fernando Rodrigues <[email protected]>
@matdibu: Hey mate, this is a rough draft so far, but I'd appreciate any comments you may have, as you're more experienced than me with the new rust-based tools. |
d3f7394
to
057564e
Compare
you're giving me too much credit, I was just playing around with XCP-ng so I decided to make the experience a bit better for NixOS that being said, this is nice, thank you! |
057564e
to
3daacbb
Compare
Sooo, this seems to cause a |
@SigmaSquadron Trying to run this by copying it into my configurations, I run into issue:
Other then that it seems to be working great |
yep, that and the fact that the ISO image is using the old option is why I just added DO NOT MERGE will fix it tomorrow |
…efault Does nothing if the ISO is not a domU, but it should write XenStore entries if we're running in a Xen VM. Signed-off-by: Fernando Rodrigues <[email protected]>
mainProgram is required for the module, but we also take the opportunity to remove the `rec` statement. Signed-off-by: Fernando Rodrigues <[email protected]>
Turns xen-domU.nix into an extension of the virtualisation.xen options, allowing users to enable the xen-guest-agent service (all VM types), and enable recommended settings for minimal PV/PVH domains. Signed-off-by: Fernando Rodrigues <[email protected]>
3daacbb
to
e51858f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
cc @ElvishJerricco as the latest ISO maintainer to be touched by the nixpkgs curse. |
To avoid merge conflicts, I'll wait for #344314 to be merged first and target this for 25.05. |
Depends on #363388 |
Description of changes
Turns the profile meant for Xen guests into a proper module that can be enabled as an option.
We also enable it by default on the graphical ISO and differentiate the wording of the
xe-guest-agent
module, which is the Citrix XenServer guest utilities.This is based on @matdibu's previous work.
A lot of testing is required before this can be merged. Any and all testers are welcome to help us out!
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review pr 341129"
. Note: all changes have to be committed, also see nixpkgs-review usageAdd a 👍 reaction to pull requests you find important.