Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

desktop-postflop: use cargo-tauri_1.hook #341073

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

desktop-postflop: use cargo-tauri_1.hook #341073

wants to merge 1 commit into from

Conversation

TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Sep 10, 2024 •
edited
Loading

Description of changes

This PR migrates the desktop-postflop package to use cargo-tauri.hook

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 10, 2024
@TomaSajt
Copy link
Contributor Author

@ofborg build desktop-postflop

@TomaSajt TomaSajt marked this pull request as draft September 12, 2024 08:42
@TomaSajt TomaSajt force-pushed the desktop-postflop branch 2 times, most recently from 5024436 to becfaaa Compare September 16, 2024 13:57
@TomaSajt TomaSajt changed the title desktop-postflop: use cargo-tauri and add darwin support desktop-postflop: use cargo-tauru.hook Oct 10, 2024
@TomaSajt TomaSajt force-pushed the desktop-postflop branch 2 times, most recently from d22f457 to 06932d2 Compare October 10, 2024 13:53
@TomaSajt TomaSajt marked this pull request as ready for review October 10, 2024 13:53
@TomaSajt TomaSajt changed the title desktop-postflop: use cargo-tauru.hook desktop-postflop: use cargo-tauri.hook Oct 30, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 1, 2024
@TomaSajt TomaSajt force-pushed the desktop-postflop branch 2 times, most recently from e29e914 to 421a736 Compare November 7, 2024 10:55
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 7, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 10, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 4, 2025
@TomaSajt TomaSajt changed the title desktop-postflop: use cargo-tauri.hook desktop-postflop: use cargo-tauri_1.hook Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomaSajt @wegank