Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.dmt-core: init at 2.1.0 #336002

Merged
merged 3 commits into from
Oct 24, 2024
Merged

python312Packages.dmt-core: init at 2.1.0 #336002

merged 3 commits into from
Oct 24, 2024

Conversation

jasonodoom
Copy link
Member

@jasonodoom jasonodoom commented Aug 20, 2024 •
edited
Loading

Description of changes

Init dmt-core lib.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jasonodoom jasonodoom requested a review from natsukium as a code owner August 20, 2024 06:05
@jasonodoom jasonodoom force-pushed the dmt-core branch 3 times, most recently from 653cc3f to 780ae6e Compare August 20, 2024 06:54
@jasonodoom jasonodoom marked this pull request as draft August 20, 2024 07:25
@jasonodoom jasonodoom force-pushed the dmt-core branch 2 times, most recently from 19e76ae to da39c87 Compare August 21, 2024 02:19
@jasonodoom jasonodoom marked this pull request as ready for review August 21, 2024 02:25
@jasonodoom jasonodoom marked this pull request as draft August 21, 2024 17:22
SuperSandro2000
SuperSandro2000 previously requested changes Aug 22, 2024
View reviewed changes
pkgs/development/python-modules/verilogae/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/verilogae/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/reprint/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/dmt-core/default.nix Outdated Show resolved Hide resolved
@jasonodoom jasonodoom force-pushed the dmt-core branch 2 times, most recently from 8e1ba66 to a87d19b Compare September 2, 2024 23:12
@jasonodoom jasonodoom force-pushed the dmt-core branch 2 times, most recently from 1567e69 to f8dca5f Compare September 4, 2024 01:31
@jasonodoom jasonodoom marked this pull request as ready for review September 4, 2024 01:36
@jasonodoom jasonodoom marked this pull request as draft September 4, 2024 01:38
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Sep 4, 2024
@ofborg ofborg bot requested a review from jleightcap September 4, 2024 02:45
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 4, 2024
@jasonodoom jasonodoom requested a review from Aleksanaa October 3, 2024 23:39
@wegank wegank force-pushed the dmt-core branch 2 times, most recently from 587114f to c22a62b Compare October 21, 2024 23:44
@wegank wegank force-pushed the dmt-core branch 2 times, most recently from 64b22eb to f6ee302 Compare October 22, 2024 00:04
@wegank wegank changed the title python3Packages.dmt-core: init at 2.1.0 python312Packages.dmt-core: init at 2.1.0 Oct 22, 2024
@fricklerhandwerk fricklerhandwerk marked this pull request as ready for review October 22, 2024 01:44
@jasonodoom
Copy link
Member Author

@wegank thanks so much for your help! I amended to add @jleightcap as he also helped me out with this!

@jasonodoom @jleightcap @wegank
python312Packages.dmt-core: init at 2.1.0
4403ded 
Co-authored-by: Jack Leightcap <[email protected]>
Co-authored-by: Weijia Wang <[email protected]>
@wegank
Copy link
Member

wegank commented Oct 23, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 336002

aarch64-darwin

⏩ 4 packages marked as broken and skipped:
  • python311Packages.dmt-core
  • python311Packages.dmt-core.dist
  • python312Packages.dmt-core
  • python312Packages.dmt-core.dist
✅ 4 packages built:
  • python311Packages.reprint
  • python311Packages.reprint.dist
  • python312Packages.reprint
  • python312Packages.reprint.dist

@wegank
Copy link
Member

wegank commented Oct 23, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 336002

aarch64-linux

✅ 12 packages built:
  • python311Packages.dmt-core
  • python311Packages.dmt-core.dist
  • python311Packages.reprint
  • python311Packages.reprint.dist
  • python311Packages.verilogae
  • python311Packages.verilogae.dist
  • python312Packages.dmt-core
  • python312Packages.dmt-core.dist
  • python312Packages.reprint
  • python312Packages.reprint.dist
  • python312Packages.verilogae
  • python312Packages.verilogae.dist

Aleksanaa
Aleksanaa approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admired

@Aleksanaa Aleksanaa merged commit 5728069 into NixOS:master Oct 24, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@natsukium natsukium Awaiting requested review from natsukium

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@jleightcap jleightcap Awaiting requested review from jleightcap

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasonodoom @wegank @SuperSandro2000 @Aleksanaa