-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/promtail: configFile for passing path as config #322426
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to mention that configFile and configuration are incompatible options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please squash your commits
b1be81b
to
05c18dc
Compare
@FliegendeWurst done ":3 |
05c18dc
to
518bc9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also tested it, and it works as it should.
Description of changes
Added an option that is used instead of the configurations attribute in case you wish to use a config file instead.
Shouldn't break existing configurations.
Things done
Built on platform(s)
Tested, as applicable:
Tested compilation of all packages that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usageTested basic functionality of all binary files (usually in
./result/bin/
)24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
Fits CONTRIBUTING.md.