Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3buddy: unstable-2019-09-29 -> 1.0 #307823

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

afh
Copy link
Member

@afh afh commented Apr 29, 2024

Description of changes

  • Update to 1.0
  • Delete unsupported dontCheck attribute (see thread started by comment on #293498)
  • Modernize package by
    • using finalAttrs
    • replacing src.sha256 with src.hash
    • removing superfluous use of pname
    • removing with lib from meta

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from prusnak April 29, 2024 20:18
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 29, 2024
@prusnak prusnak merged commit c8148ed into NixOS:master Apr 29, 2024
24 checks passed
@afh
Copy link
Member Author

afh commented Apr 29, 2024

Thanks for merging this so quickly, @prusnak, much appreciated! 💯

@afh afh deleted the update-py3buddy branch April 29, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants