-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python2Packages.wcwidth: fix build #292007
Conversation
@ofborg build python2Packages.wcwidth |
Hey thank you for the quick response! I guess ofborg would not be helpful though, as python2 has been marked insecure. I tried building locally with Update: just discovered that |
Yes, ofborg can't help here. |
Good news! @fabaff Result of 3 packages built (previously failing):
Not sure why `wcwidth` itself is not showing, but the log seems to confirm it builds fine:https://github.com/bryango/nix-build-action/actions/runs/8077294105/job/22067301483 building '/nix/store/ymsxq9lga1iq1mbz48yfqczdn4k4mnkq-fahviewer-7.6.21.drv'...
building '/nix/store/mnm3zadpzv7f92wvmzqqz9a9spa4rm6a-pip-install-hook.drv'...
building '/nix/store/hrqk94svs5a5v9xisplkq0j4v8l3m92v-python-imports-check-hook.sh.drv'...
building '/nix/store/jg61dkj7kwjlw2xbkfi4fzrrf2i1pwrk-setuptools-44.0.0-sdist.tar.gz.drv'...
building '/nix/store/qyvx2s95sdf0c5pxwklz8b2pmp4m6j8w-setuptools-setup-hook.drv'...
building '/nix/store/iyfz727lc8djh3pqxp1pf3xl6fb6x4bn-unittest-check-hook.drv'...
building '/nix/store/w05p1ip27ryf9mccsvnpapad3ahi3clf-wrap-python-hook.drv'...
building '/nix/store/a2664b3avy6r2gzc6py074s8id2rdjc4-python2.7-bootstrapped-pip-20.3.4.drv'...
building '/nix/store/b7qshifl0yb0prq0q740jb82zgyj50da-python2.7-setuptools-44.0.0.drv'...
building '/nix/store/mq05dm7v9pjx3zj0im9rlj100cq1ndca-python-catch-conflicts-hook.drv'...
building '/nix/store/5csn9z2x2bv2a9fifhczsh54njb7xfmr-setuptools-check-hook.drv'...
building '/nix/store/zpvmzggkh1vnk8mdp4affdk265zm1fp8-python2.7-dbus-python-1.2.18.drv'...
building '/nix/store/fgril8nn33jnnjx58z7bgvxsf3q86izq-python2.7-pip-20.3.4.drv'...
building '/nix/store/n9vcslrn43jxk126b7i99l3m4bplddq2-python2.7-pygobject-2.28.7.drv'...
building '/nix/store/absscnrq5afpz8w398c5jnzvwqsnv5xj-python2.7-wheel-0.37.1.drv'...
building '/nix/store/i3j10dlyc3kggz2s2577hi5p8930p9h1-setuptools-setup-hook.drv'...
building '/nix/store/k2hy85apgfcbdams5qzfl99v4f393vii-pip-build-hook.sh.drv'...
building '/nix/store/dsdb91pjqyjl3ypw4qcqqqiqn2gri9q4-pip-install-hook.drv'...
building '/nix/store/97abaxymyi4q9kmqjbjp20y42nr6walz-python2.7-atomicwrites-1.4.1.drv'...
building '/nix/store/f8q9pgyvhzhbkgw6zv4rqz6glf6yxrh6-python2.7-attrs-21.4.0.drv'...
building '/nix/store/wz1zqiff073qk3b0m9qs8dnz6r1d8ghv-python2.7-contextlib2-0.6.0.post1.drv'...
building '/nix/store/x8z450kz3sb95k00pivr8nb918nsnq6g-python2.7-coverage-5.5.drv'...
building '/nix/store/pp0r2mw6jqggw7g0qf5lh31wljlqzg85-python2.7-enum34-1.1.10.drv'...
building '/nix/store/9m4qwls31imnm6c4bzmy636vqwzn012i-python2.7-funcsigs-1.0.2.drv'...
building '/nix/store/2md2kxv77w4x86xxf7lm6za9jgay93n3-python2.7-pbr-6.0.0.drv'...
building '/nix/store/0nci0bmyrhs2gqrxa83g177gpjhaw2cw-python2.7-nose-1.3.7.drv'...
building '/nix/store/qr6af0a5skqwlhqf0i70qd9x4c18427b-python2.7-pyparsing-2.4.7.drv'...
building '/nix/store/wvfxqpl42yf09klfrwrl6bq0v9hyqwk2-python2.7-scandir-1.10.0.drv'...
building '/nix/store/i4d0xrh1993f5qhbxyvkb00cic5gvg3p-python2.7-six-1.16.0.drv'...
building '/nix/store/gvqwa1wa2fnghxzyivzc8gqvn6xky0hr-python2.7-sortedcontainers-2.4.0.drv'...
building '/nix/store/2c11hkwws5skpq94kvw13sgh31smazn5-python2.7-toml-0.10.2.drv'...
building '/nix/store/qlzfaw9mky86pvqwna71n9apyil0yd7k-python2.7-mock-3.0.5.drv'...
building '/nix/store/p68chdl41h03bkcx5gg8z61qz7506yp1-python2.7-hypothesis-4.57.1.drv'...
building '/nix/store/kkr7kv53nikhczxfkwcvxx4vad9nj23i-python2.7-more-itertools-5.0.0.drv'...
building '/nix/store/7an6xzlbl5lgg5xgijbkjnwfhifhfxn4-python2.7-packaging-20.4.drv'...
building '/nix/store/mld0wzpwnpwag1njw7fflq0hjfgsaaas-python2.7-setuptools_scm-5.0.2.drv'...
building '/nix/store/1c0d6z0i4wvnsydaiwv4201x4fnjwf59-python2.7-typing-3.10.0.0.drv'...
building '/nix/store/5jyqwla865q6bybfmlhrgidw62ymcb6b-python2.7-backports-functools-lru-cache-1.6.6.drv'...
building '/nix/store/3665pzp3f2phvdd6h3v2qi7bbxba79b2-python2.7-configparser-4.0.2.drv'...
building '/nix/store/brsrn9v5xb3ys4237f1qqjx4fv7p48r1-python2.7-py-1.11.0.drv'...
building '/nix/store/qdcx781xpr1wl1rfa228a3v2dc1h6mil-python2.7-pathlib2-2.3.7.post1.drv'...
building '/nix/store/f7lmdd2qd7wnbshfb3jca73viwji25k0-python2.7-zipp-1.0.0.drv'...
building '/nix/store/dlgri4gb4zbq3krpfy7d3j9inn2as2nh-python2.7-wcwidth-0.2.13.drv'...
building '/nix/store/03smwmy0d36lpqmbcccwybks798xx08g-python2.7-importlib-metadata-2.1.1.drv'...
building '/nix/store/7wljmpz4a1l5di22v59qan69sngi1mk6-python2.7-pluggy-0.13.1.drv'...
building '/nix/store/xjcfmq19zqbklm0dnaph3zx6j24jhz2b-python2.7-pytest-4.6.11.drv'...
building '/nix/store/s7772gyfm3g135808755sck9rmny4rv8-python2.7-pycairo-1.18.2.drv'...
building '/nix/store/r4s2j2lssr3dphk8rjvlr6mnkzg4s0jk-python2.7-pygtk-2.24.0.drv'...
building '/nix/store/n6c1kdjkwaazhv76zqghmr6845ql68ms-neard-0.18.drv'...
building '/nix/store/vhbmn93ra0jc2vncqqr15fqiy7zh6ldq-python-2.7.18.7-env.drv'...
building '/nix/store/s8gzms2y3vyyb0105s4bbslyfpgahzqc-fahcontrol-7.6.21.drv'...
building '/nix/store/qxzlswiz5b79s2fk40b5ba9695yfvmwx-review-shell.drv'... |
c16c951
to
a7bf89d
Compare
284e3db
to
436fb99
Compare
As of version 0.2.13 upstream still supports python2. In the future, this package should be dropped or pinned to the last working version after the final release for python2.
Add myself in maintainers, and make sure that python3 maintainers is _not_ pinged for python2 issues.
436fb99
to
5ebb67e
Compare
Oh nice thank you very much for merging this! |
python2Packages.wcwidth
is disabled in https://github.com/NixOS/nixpkgs/pull/289229/files#diff-e3660b6955728047c993d60ff4af021e2f83ac4b8abd771938015a31141dc913R14. However, as of version 0.2.13 upstream still supports python2, so we re-enabled it in this commit. In the future, this package should be dropped or pinned to the last working version after upstream's final release for python2. See:Friendly ping @fabaff for comments 😉
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.