Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python311Packages.scs: relax floating point precision for linux test #284299

Merged
2 commits merged into from Feb 1, 2024
Merged

python311Packages.scs: relax floating point precision for linux test #284299

2 commits merged into from Feb 1, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 27, 2024 •
edited by ghost
Loading

workaround for: bodono/scs-python#81 with upstream patch bodono/scs-python#82

after the update to scipy 1.12 the test_solve_feasible fails on linux with 1 of the 185 floating point values not being equal to 4 decimal places. relax the check to only check 3 decimal places.

build failures related to python311Packages.osqp failing
https://hydra.nixos.org/build/247560486
osqp/osqp-python#121

Result of nixpkgs-review pr 284299 run on x86_64-linux 1

12 packages failed to build:
  • python311Packages.bambi
  • python311Packages.bambi.dist
  • python311Packages.blackjax
  • python311Packages.blackjax.dist
  • python311Packages.cvxpy
  • python311Packages.cvxpy.dist
  • python311Packages.jaxopt
  • python311Packages.jaxopt.dist
  • python311Packages.qpsolvers
  • python311Packages.qpsolvers.dist
  • python311Packages.qutip
  • python311Packages.qutip.dist
2 packages built:
  • python311Packages.scs
  • python311Packages.scs.dist

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ghost ghost requested review from SomeoneSerge and GaetanLepage January 27, 2024 16:57
@ofborg ofborg bot requested a review from drewrisinger January 27, 2024 17:25
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 27, 2024
@GaetanLepage
Copy link
Contributor

Result of nixpkgs-review pr 284299 run on x86_64-linux 1

12 packages failed to build:
  • python311Packages.bambi
  • python311Packages.bambi.dist
  • python311Packages.blackjax
  • python311Packages.blackjax.dist
  • python311Packages.cvxpy
  • python311Packages.cvxpy.dist
  • python311Packages.jaxopt
  • python311Packages.jaxopt.dist
  • python311Packages.qpsolvers
  • python311Packages.qpsolvers.dist
  • python311Packages.qutip
  • python311Packages.qutip.dist
2 packages built:
  • python311Packages.scs
  • python311Packages.scs.dist

@ghost
Copy link
Author

ghost commented Jan 27, 2024 •
edited by ghost
Loading

Result of nixpkgs-review pr 284299 run on x86_64-linux 1
12 packages failed to build:

related to python311Packages.osqp failing after scipy 1.12 update
https://hydra.nixos.org/build/247560486
osqp/osqp-python#121

@ghost ghost mentioned this pull request Jan 27, 2024
Closed
@ghost
Copy link
Author

ghost commented Jan 27, 2024

failures in osqp after scipy update seem significant. https://hydra.nixos.org/build/247560486
opened issue: #284308
moving this to draft as could be scipy issue.

@ghost ghost marked this pull request as draft January 27, 2024 18:07
doronbehar
doronbehar reviewed Jan 27, 2024
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and legitimate to me. Thanks for working on this! Why is this a draft? Oh I see why.. I think this could be good to go.

@ghost
Copy link
Author

ghost commented Jan 27, 2024

Looks good and legitimate to me. Thanks for working on this! Why is this a draft? Oh I see why.. I think this could be good to go.

after seeing the failures in osqp/osqp-python#121 i thought i'd hold off for a few days and see if anyone responds to the bug reports. the underling implementations of these packages are c/c++/fortran libraries. in the modules scipy seems to be used just to do sparse matrix conversions -- but the tests use it to compare output from the underlying libs. unclear if failures are due to bugs in the unit tests triggered by the update or problems with scipy 1.12

@doronbehar
Copy link
Contributor

I understand. Yes let's give the upstreams a bit of time to investigate these issues.

annalee added 2 commits February 1, 2024 01:15
python311Packages.scs: relax floating point precision
eec43fd 
after the update to scipy 1.12 the test_solve_feasible fails on linux
with 1 of the 185 floating point values not being equal to 4 decimal
places. relax the check to only check 3 decimal places.
python311Packages.scs: enable all tests
de23b55
@ghost ghost marked this pull request as ready for review February 1, 2024 11:41
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Feb 1, 2024
@ghost ghost merged commit 734904a into NixOS:master Feb 1, 2024
26 checks passed
@ghost ghost deleted the scs-relax-test-linux branch February 1, 2024 18:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SomeoneSerge SomeoneSerge Awaiting requested review from SomeoneSerge

@GaetanLepage GaetanLepage Awaiting requested review from GaetanLepage

@drewrisinger drewrisinger Awaiting requested review from drewrisinger

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GaetanLepage @doronbehar