qrencode: Add support for PIC image type

[afh]

Description of changes

This PR adds the changes from fukuchi/libqrencode#208 PR, to the qrencode nixpkgs.
fukuchi/libqrencode#208 brings support for the PIC (a graphics format used with groff and TeX) image type.

ℹ️ The add_pic_image_type.patch patch slightly differs from the changes proposed in fukuchi/libqrencode#208 as those target the master branch, where nixpkgs patch file targets the latest release, i.e. 4.1.1

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[afh]

Yikes, I did not expect this PR to trigger so many rebuilds. Please let me know if this PRs merge-base should rather be staging than master.

[Ma27]

Yes, definitely.

However I have another issue with this: I'm not convinced that it's a good idea to add a bunch of unreviewed C code to our repos. No offense, but bearing in mind the amount of CVEs in C code from image libraries (imagemagick, libjpeg, etc) I don't think it's wise to apply third-party patches here that didn't even have a review from the authors.

Also, in my experience we don't really apply patches on our own that are not security fixes or changes to make the software runnable under NixOS.

All in all, I'd prefer to reject this[1], but I'll leave the final call to our qrencode maintainers.

[1] your best option IMHO is to apply the patch yourself in your config, e.g. via

{ pkgs, ... }:

{
 environment.systemPackages = [
    (qrencode.overrideAttrs ({ patches ? [], ... }: {
      patches = patches ++ [ ./pic-support.patch ];
    });
  ];
}

[afh]

Thank you for your feedback and context, @Ma27. I'm going to retract and close this PR as I agree with your point that only patches for "security fixes or changes to make the software runnable under NixOS" should be applied.

Hopefully the maintainer of the upstream qrencode will take the time to review and include the proposed patch to add pic image support at some point in the future and create another release.