Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python310Packages.bqplot: init at 0.12.36 #217583

Merged
merged 2 commits into from
May 21, 2023
Merged

python310Packages.bqplot: init at 0.12.36 #217583

merged 2 commits into from
May 21, 2023

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Feb 21, 2023 •
edited
Loading

Description of changes

Add a package and its dependency.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 22, 2023
@bcdarwin bcdarwin force-pushed the python3-bqplot branch 2 times, most recently from c4ed568 to 3d65e38 Compare February 22, 2023 03:36
@bcdarwin bcdarwin requested a review from dotlambda February 22, 2023 03:36
@dotlambda
Copy link
Member

Result of nixpkgs-review pr 217583 run on x86_64-linux 1

4 packages failed to build:
  • python310Packages.bqplot
  • python310Packages.bqscales
  • python311Packages.bqplot
  • python311Packages.bqscales

@bcdarwin
Copy link
Member Author

Reverted jupyterlab -> jupyter-packaging.

@dotlambda
Copy link
Member

Reverted jupyterlab -> jupyter-packaging.

Can you open an upstream issue about their pyproject.toml being wrong?

@bcdarwin
Copy link
Member Author

bcdarwin commented Feb 22, 2023 •
edited
Loading

Reverted jupyterlab -> jupyter-packaging.

Can you open an upstream issue about their pyproject.toml being wrong?

@dotlambda bqplot/bqscales#76

@marsam marsam merged commit 1ce006a into NixOS:master May 21, 2023
@bcdarwin bcdarwin deleted the python3-bqplot branch May 22, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcdarwin @dotlambda @marsam