Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.warcio: init at 1.7.4 #139766

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Sep 28, 2021

Motivation for this change

This is a dependency of ipwb, which I plan to add in the future.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 28, 2021
@Luflosi
Copy link
Contributor Author

Luflosi commented Sep 28, 2021

Upatream responded to the test issue very quickly. I'll see if I can manage to create a PR upstream. In the meantime, I'll mark this PR as WIP.

@Luflosi Luflosi marked this pull request as draft September 28, 2021 14:51
@Luflosi
Copy link
Contributor Author

Luflosi commented Oct 18, 2021

I created webrecorder/warcio#135, which adds an offline option for the tests. It hasn't been merged yet, so I just included the changes as a patch.

@Luflosi Luflosi marked this pull request as ready for review October 18, 2021 14:32
@Luflosi
Copy link
Contributor Author

Luflosi commented Jan 27, 2022

Fixed the conflict.

@Luflosi
Copy link
Contributor Author

Luflosi commented Jan 28, 2022

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2 label Jan 28, 2022
@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 28, 2022

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the needs_reviewer (old Marvin label, do not use) label Jan 28, 2022
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 139766 run on x86_64-linux 1

2 packages built:
  • python310Packages.warcio
  • python39Packages.warcio

@marvin-mk2 marvin-mk2 bot added awaiting_reviewer (old Marvin label, do not use) and removed needs_reviewer (old Marvin label, do not use) labels Jan 28, 2022
@SuperSandro2000 SuperSandro2000 merged commit ae79b7b into NixOS:master Jan 28, 2022
@Luflosi Luflosi deleted the add-warcio branch January 28, 2022 10:58
@Luflosi
Copy link
Contributor Author

Luflosi commented Jan 28, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes awaiting_reviewer (old Marvin label, do not use) marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants