[WIP] Implement Admin View #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alaust-dev
force-pushed
the
feature/admin-view
branch
from
e5c9535 to
2d12854
Compare
jonas-be
requested changes
Jun 21, 2023
| }) | ||
|
|
||
| switch (response.status) { | ||
| case 200: |
There was a problem hiding this comment.
There are more possible status codes. Look at the openAPI spec: https://github.com/NimbusX-CMS/NimbusX-content-managing-service/blob/develop/api.yaml
There was a problem hiding this comment.
Nope there are only 200, 500 and a missing 401 Unauthorized which should be added after authentication is implemented: https://github.com/NimbusX-CMS/NimbusX-content-managing-service/blob/27792246c46b1aed5d03413336d8b6e88e5d877c/api.yaml#L315
Co-authored-by: Jonas Bender <[email protected]>
alaust-dev
force-pushed
the
feature/admin-view
branch
from
095f557 to
830cfd1
Compare
alaust-dev
force-pushed
the
feature/admin-view
branch
from
a7b9d9d to
34289a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.