PR comment suggestions and fixes

Remove unnecessary delete Revert deleting Close method call
NightTsarina · Nov 11, 2021 · 9b2d7a9 · 9b2d7a9
1 parent 92c7d8d
commit 9b2d7a9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,3 +1,3 @@
 [build-system]
-requires = ["setuptools", "wheel", "Cython"]
+requires = ["setuptools", "wheel", "cython"]
 build-backend = "setuptools.build_meta"
diff --git a/rocksdb/_rocksdb.pyx b/rocksdb/_rocksdb.pyx
@@ -1738,6 +1738,7 @@ cdef class DB(object):
                     copts.in_use = False
             del self.cf_options[:]
             with nogil:
+                st = self.db.Close()
                 self.db = NULL
             if self.opts is not None:
                 self.opts.in_use = False