refactor to inherit from collection #47
Conversation
add subdir to the stored object so when you get it, you know where to actually retrieve the file from
makes all of the standard deployd queries work, makes the script domains consistent with deployd, makes the dashboard work as expected
|
Looks good. 👍 |
# Conflicts: # index.js
|
ok, i got this done. i might need to do a PR for the demo repo as well to support the changes. |
|
@EvilDrW |
|
I have been testing this fork and it seems like a great step forward! PUT support is definitely missed, especially if you just want to update a non-file-related field, but there are ways to work around this of course. 👍 |
|
@israelroldan thanks for the feedback, I'll take care of this (I also have to publish a new release of deployd :/ ) |
refactor to inherit from collection
|
Thanks a lot @EvilDrW for your contribution! |
|
@EvilDrW Let me know if all works fine, and I'll make a final release |
in my opinion, it is better for the fileupload resource to inherit from collection, not resource. doing so gives us the advantage of maintaining a consistent interface with deployd (queries, script domains, etc. are identical to what deployd supplies).
in addition, it makes the code much shorter and most importantly gives us access to the dashboard to show all of the files.
as an aside, i sacrificed the option to not have unique filenames. to me it was problematic because of the possibility of clobbering someone else's files.