Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement profile create. #16

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

bywindow
Copy link
Collaborator

@bywindow bywindow commented Aug 3, 2024

  • 프로필 생성 구현
  • API base response model 추가 (NetworkResult, ResultHandler)
    • 사용예시
    override suspend fun saveProfile(nickname: String, index: Int): NetworkResult<Unit> = handleResult {
          val request = SaveProfileRequest.createRequest(nickname, index)
          profileService.saveProfile(request)
      }
    

@bywindow bywindow requested a review from eshc123 August 3, 2024 18:05
@bywindow bywindow self-assigned this Aug 3, 2024
@bywindow bywindow force-pushed the feature/implement-profile-create branch from 5b06fd0 to 76157c1 Compare August 3, 2024 18:07
@bywindow bywindow force-pushed the feature/implement-profile-create branch from 76157c1 to 9e80ec4 Compare August 3, 2024 18:07
Copy link
Member

@eshc123 eshc123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어, 정상 작동은 확인했는데!
프로필 이름 입력에서 한글 입력 관련해서만 확인해줘!

@bywindow bywindow force-pushed the feature/implement-profile-create branch from f6e5656 to b1922c4 Compare August 5, 2024 12:30
@bywindow bywindow force-pushed the feature/implement-profile-create branch from b1922c4 to a98d038 Compare August 5, 2024 12:32
@bywindow bywindow force-pushed the feature/implement-profile-create branch from a98d038 to 27e16f5 Compare August 5, 2024 12:33
@bywindow bywindow merged commit 4274791 into dev Aug 5, 2024
1 check passed
@bywindow bywindow deleted the feature/implement-profile-create branch August 5, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants