[CAT-93] DesignSystem 구축 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jihyun247
approved these changes
Aug 7, 2024
Comment on lines
+87
to
+88
| interactionItem(interaction: Global.Color.black.opacity(Alias.Interaction.hover), name: "Hover") | ||
| interactionItem(interaction: Global.Color.black.opacity(Alias.Interaction.pressed), name: "Pressed") |
There was a problem hiding this comment.
interaction token은 컬러는 안가지고 opacity만 가지는 토큰이라서 이렇게 수정한거야? ? ?
There was a problem hiding this comment.
엉 opacty는 여러 색상에 대응해서 들어가야해서 Color가 아니라 Double을 반환하도록 했어
Comment on lines
+30
to
+31
| public struct BarButtonDetail<Title: View, LeftIcon: View, RightIcon: View>: View { | ||
| @Environment(\.barButtonDetailStyle) private var style |
There was a problem hiding this comment.
bar button detail 뷰랑 스타일 신기하다 .. ! 필요한 configuration 받아서 resolve 하는 과정 잘봤슴다 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#100] FEAT : 로그인 구현
관련된 문서 📄
무엇에 관한 PR 인가요? 🙋
어떤 것을 작업하셨나요? 🛠
🌱 PR Point