[Feature/#335] 문답 화면 텍스트필드 버그 수정 #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
완료 버튼 활성화 여부가 isDisabledButton가 textFieldState에 의해 결정돼서 text field와 관련된 상태 값들만 반영해서 버튼 활성화 여부 상태 조절할 수 있는데 feature에 연산 프로퍼티로 버튼 활성화 여부 관리(첫번째 사진 처림!)하면 QuestionAndAnswerFeature 에 있는 다른 상태들이랑도 엮에서 상태관리도 할 수 있고 좀 더 다양한 상황 대응해 줄 수 있을거같아서 피처에서 연산프로퍼티로 관리할 수 있게 해보면 어떨까??? |
JongHoooon
reviewed
Nov 2, 2024
| @@ -24,6 +24,22 @@ extension QuestionAndAnswerFeature { | |||
| state.configurePingPong(pingPong) | |||
| return .none | |||
|
|
|||
| case let .focusedFieldDidChanged(field): | |||
| guard let previousFocustedField = state.focusedField else { | |||
JongHoooon
approved these changes
Nov 5, 2024
- previousFocustedField -> previousFocusedField
leemhyungyu
force-pushed
the
feature/#335-문답-화면-텍스트필드-버그-수정
branch
from
921dc6c to
1aad5a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 #335
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2024-10-25.at.16.20.30.mp4
완료된 기능
고민했던 부분
문제가 있었던 부분이 TextField의 포커스가 풀리게 되면 무조건 Active 상태로 설정되게 로직이 짜여져 있어서 어떻게 할지 고민하다가
Feature 내부에 현재 포커스된 TextField에 대한 정보를 가지고 이를 통해 포커스가 벗어났을 때 이전 포커스된 TextField의 글자수에 따라 상태를 관리하는 것으로 수정함!