Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

일회성 이벤트를 처리하는 방법을 SharedFlow 에서 Channel 로 변경 #157

Merged
merged 1 commit into from
Mar 14, 2024
Merged

일회성 이벤트를 처리하는 방법을 SharedFlow 에서 Channel 로 변경 #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions ...plete/src/main/kotlin/com/nexters/bandalart/android/feature/complete/CompleteViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,11 @@ import com.nexters.bandalart.android.feature.complete.navigation.BANDALART_TITLE
import dagger.hilt.android.lifecycle.HiltViewModel
import javax.inject.Inject
import kotlinx.coroutines.Job
import kotlinx.coroutines.flow.MutableSharedFlow
import kotlinx.coroutines.channels.Channel
import kotlinx.coroutines.flow.MutableStateFlow
import kotlinx.coroutines.flow.SharedFlow
import kotlinx.coroutines.flow.StateFlow
import kotlinx.coroutines.flow.asSharedFlow
import kotlinx.coroutines.flow.asStateFlow
import kotlinx.coroutines.flow.receiveAsFlow
import kotlinx.coroutines.flow.update
import kotlinx.coroutines.launch
import timber.log.Timber
Expand Down Expand Up @@ -58,8 +57,8 @@ class CompleteViewModel @Inject constructor(
private val _uiState = MutableStateFlow(CompleteUiState())
val uiState: StateFlow<CompleteUiState> = this._uiState.asStateFlow()

private val _eventFlow = MutableSharedFlow<CompleteUiEvent>()
val eventFlow: SharedFlow<CompleteUiEvent> = _eventFlow.asSharedFlow()
private val _eventChannel = Channel<CompleteUiEvent>()
val eventFlow = _eventChannel.receiveAsFlow()

init {
initComplete()
Expand Down Expand Up @@ -98,7 +97,7 @@ class CompleteViewModel @Inject constructor(

result.isFailure -> {
val exception = result.exceptionOrNull()!!
_eventFlow.emit(CompleteUiEvent.ShowToast(UiText.DirectString(exception.message.toString())))
_eventChannel.send(CompleteUiEvent.ShowToast(UiText.DirectString(exception.message.toString())))
Timber.e(exception)
}
}
Expand All @@ -112,7 +111,7 @@ class CompleteViewModel @Inject constructor(

fun navigateToHome() {
viewModelScope.launch {
_eventFlow.emit(CompleteUiEvent.NavigateToHome)
_eventChannel.send(CompleteUiEvent.NavigateToHome)
}
}
}
19 changes: 9 additions & 10 deletions ...c/main/kotlin/com/nexters/bandalart/android/feature/home/BandalartBottomSheetViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,15 @@ import com.nexters.bandalart.android.feature.home.model.UpdateBandalartMainCellM
import com.nexters.bandalart.android.feature.home.model.UpdateBandalartSubCellModel
import com.nexters.bandalart.android.feature.home.model.UpdateBandalartTaskCellModel
import dagger.hilt.android.lifecycle.HiltViewModel
import javax.inject.Inject
import kotlinx.coroutines.flow.MutableSharedFlow
import kotlinx.coroutines.channels.Channel
import kotlinx.coroutines.flow.MutableStateFlow
import kotlinx.coroutines.flow.SharedFlow
import kotlinx.coroutines.flow.StateFlow
import kotlinx.coroutines.flow.asSharedFlow
import kotlinx.coroutines.flow.asStateFlow
import kotlinx.coroutines.flow.receiveAsFlow
import kotlinx.coroutines.flow.update
import kotlinx.coroutines.launch
import timber.log.Timber
import javax.inject.Inject

/**
* BottomSheetUiState
Expand Down Expand Up @@ -65,8 +64,8 @@ class BottomSheetViewModel @Inject constructor(
private val _uiState = MutableStateFlow(BottomSheetUiState())
val uiState: StateFlow<BottomSheetUiState> = _uiState.asStateFlow()

private val _eventFlow = MutableSharedFlow<BottomSheetUiEvent>()
val eventFlow: SharedFlow<BottomSheetUiEvent> = _eventFlow.asSharedFlow()
private val _eventChannel = Channel<BottomSheetUiEvent>()
val eventFlow = _eventChannel.receiveAsFlow()

fun copyCellData(cellData: BandalartCellUiModel) {
_uiState.update {
Expand Down Expand Up @@ -102,7 +101,7 @@ class BottomSheetViewModel @Inject constructor(

result.isFailure -> {
val exception = result.exceptionOrNull()!!
_eventFlow.emit(BottomSheetUiEvent.ShowToast(UiText.DirectString(exception.message.toString())))
_eventChannel.send(BottomSheetUiEvent.ShowToast(UiText.DirectString(exception.message.toString())))
Timber.e(exception.message)
}
}
Expand Down Expand Up @@ -132,7 +131,7 @@ class BottomSheetViewModel @Inject constructor(

result.isFailure -> {
val exception = result.exceptionOrNull()!!
_eventFlow.emit(BottomSheetUiEvent.ShowToast(UiText.DirectString(exception.message.toString())))
_eventChannel.send(BottomSheetUiEvent.ShowToast(UiText.DirectString(exception.message.toString())))
Timber.e(exception.message)
}
}
Expand Down Expand Up @@ -162,7 +161,7 @@ class BottomSheetViewModel @Inject constructor(

result.isFailure -> {
val exception = result.exceptionOrNull()!!
_eventFlow.emit(BottomSheetUiEvent.ShowToast(UiText.DirectString(exception.message.toString())))
_eventChannel.send(BottomSheetUiEvent.ShowToast(UiText.DirectString(exception.message.toString())))
Timber.e(exception.message)
}
}
Expand All @@ -189,7 +188,7 @@ class BottomSheetViewModel @Inject constructor(
it.copy(isCellDeleted = false)
}
openDeleteCellDialog(false)
_eventFlow.emit(BottomSheetUiEvent.ShowToast(UiText.DirectString(exception.message.toString())))
_eventChannel.send(BottomSheetUiEvent.ShowToast(UiText.DirectString(exception.message.toString())))
Timber.e(exception.message)
}
}
Expand Down
25 changes: 12 additions & 13 deletions feature/home/src/main/kotlin/com/nexters/bandalart/android/feature/home/HomeViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,11 @@ import kotlinx.collections.immutable.ImmutableList
import kotlinx.collections.immutable.persistentListOf
import kotlinx.collections.immutable.toImmutableList
import kotlinx.coroutines.async
import kotlinx.coroutines.flow.MutableSharedFlow
import kotlinx.coroutines.channels.Channel
import kotlinx.coroutines.flow.MutableStateFlow
import kotlinx.coroutines.flow.SharedFlow
import kotlinx.coroutines.flow.StateFlow
import kotlinx.coroutines.flow.asSharedFlow
import kotlinx.coroutines.flow.asStateFlow
import kotlinx.coroutines.flow.receiveAsFlow
import kotlinx.coroutines.flow.update
import kotlinx.coroutines.launch
import timber.log.Timber
Expand Down Expand Up @@ -111,8 +110,8 @@ class HomeViewModel @Inject constructor(
private val _uiState = MutableStateFlow(HomeUiState())
val uiState: StateFlow<HomeUiState> = _uiState.asStateFlow()

private val _eventFlow = MutableSharedFlow<HomeUiEvent>()
val eventFlow: SharedFlow<HomeUiEvent> = _eventFlow.asSharedFlow()
private val _eventChannel = Channel<HomeUiEvent>()
val eventFlow = _eventChannel.receiveAsFlow()

init {
_uiState.update { it.copy(isShowSkeleton = true) }
Expand Down Expand Up @@ -272,7 +271,7 @@ class HomeViewModel @Inject constructor(
_uiState.update { it.copy(isNetworking = true) }
viewModelScope.launch {
if (_uiState.value.bandalartList.size + 1 > 5) {
_eventFlow.emit(HomeUiEvent.ShowToast(UiText.StringResource(R.string.limit_create_bandalart)))
_eventChannel.send(HomeUiEvent.ShowToast(UiText.StringResource(R.string.limit_create_bandalart)))
return@launch
}
_uiState.update { it.copy(isShowSkeleton = true) }
Expand All @@ -289,7 +288,7 @@ class HomeViewModel @Inject constructor(
setRecentBandalartKey(bandalart.key)
// 새로운 반다라트를 로컬에 저장
upsertBandalartKey(bandalart.key)
_eventFlow.emit(HomeUiEvent.ShowSnackbar(UiText.StringResource(R.string.create_bandalart)))
_eventChannel.send(HomeUiEvent.ShowSnackbar(UiText.StringResource(R.string.create_bandalart)))
}

result.isSuccess && result.getOrNull() == null -> {
Expand All @@ -304,7 +303,7 @@ class HomeViewModel @Inject constructor(
isShowSkeleton = false,
)
}
_eventFlow.emit(HomeUiEvent.ShowToast(UiText.DirectString(exception.message.toString())))
_eventChannel.send(HomeUiEvent.ShowToast(UiText.DirectString(exception.message.toString())))
}
}
_uiState.update { it.copy(isNetworking = false) }
Expand All @@ -327,7 +326,7 @@ class HomeViewModel @Inject constructor(
openBandalartDeleteAlertDialog(false)
getBandalartList()
deleteBandalartKey(bandalartKey)
_eventFlow.emit(HomeUiEvent.ShowSnackbar(UiText.StringResource(R.string.delete_bandalart)))
_eventChannel.send(HomeUiEvent.ShowSnackbar(UiText.StringResource(R.string.delete_bandalart)))
}

result.isSuccess && result.getOrNull() == null -> {
Expand All @@ -343,7 +342,7 @@ class HomeViewModel @Inject constructor(
isBandalartDeleted = false,
)
}
_eventFlow.emit(HomeUiEvent.ShowToast(UiText.DirectString(exception.message.toString())))
_eventChannel.send(HomeUiEvent.ShowToast(UiText.DirectString(exception.message.toString())))
}
}
_uiState.update { it.copy(isNetworking = false) }
Expand Down Expand Up @@ -376,7 +375,7 @@ class HomeViewModel @Inject constructor(
isShowSkeleton = false,
)
}
_eventFlow.emit(HomeUiEvent.ShowToast(UiText.DirectString(exception.message.toString())))
_eventChannel.send(HomeUiEvent.ShowToast(UiText.DirectString(exception.message.toString())))
}
}
_uiState.update { it.copy(isNetworking = false) }
Expand All @@ -403,7 +402,7 @@ class HomeViewModel @Inject constructor(

result.isFailure -> {
val exception = result.exceptionOrNull()!!
_eventFlow.emit(HomeUiEvent.ShowToast(UiText.DirectString(exception.message.toString())))
_eventChannel.send(HomeUiEvent.ShowToast(UiText.DirectString(exception.message.toString())))
}
}
_uiState.update { it.copy(isNetworking = false) }
Expand Down Expand Up @@ -482,7 +481,7 @@ class HomeViewModel @Inject constructor(

fun navigateToComplete() {
viewModelScope.launch {
_eventFlow.emit(
_eventChannel.send(
HomeUiEvent.NavigateToComplete(
key = uiState.value.bandalartDetailData.key,
title = uiState.value.bandalartDetailData.title!!,
Expand Down
11 changes: 5 additions & 6 deletions ...g/src/main/kotlin/com/nexters/bandalart/android/feature/onboarding/OnBoardingViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@ import androidx.lifecycle.ViewModel
import androidx.lifecycle.viewModelScope
import com.nexters.bandalart.android.core.domain.usecase.bandalart.SetOnboardingCompletedStatusUseCase
import dagger.hilt.android.lifecycle.HiltViewModel
import kotlinx.coroutines.flow.MutableSharedFlow
import kotlinx.coroutines.flow.SharedFlow
import kotlinx.coroutines.flow.asSharedFlow
import kotlinx.coroutines.channels.Channel
import kotlinx.coroutines.flow.receiveAsFlow
import kotlinx.coroutines.launch
import javax.inject.Inject

Expand All @@ -18,8 +17,8 @@ sealed interface OnBoardingUiEvent {
class OnboardingViewModel @Inject constructor(
private val setOnboardingCompletedStatusUseCase: SetOnboardingCompletedStatusUseCase,
) : ViewModel() {
private val _eventFlow = MutableSharedFlow<OnBoardingUiEvent>()
val eventFlow: SharedFlow<OnBoardingUiEvent> = _eventFlow.asSharedFlow()
private val _eventChannel = Channel<OnBoardingUiEvent>()
val eventFlow = _eventChannel.receiveAsFlow()

fun setOnboardingCompletedStatus(flag: Boolean) {
viewModelScope.launch {
Expand All @@ -30,7 +29,7 @@ class OnboardingViewModel @Inject constructor(

private fun navigateToHome() {
viewModelScope.launch {
_eventFlow.emit(OnBoardingUiEvent.NavigateToHome)
_eventChannel.send(OnBoardingUiEvent.NavigateToHome)
}
}
}
13 changes: 6 additions & 7 deletions ...re/splash/src/main/kotlin/com/nexters/bandalart/android/feature/splash/SplashViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,12 @@ import com.nexters.bandalart.android.core.domain.usecase.login.CreateGuestLoginT
import com.nexters.bandalart.android.core.domain.usecase.login.GetGuestLoginTokenUseCase
import com.nexters.bandalart.android.core.domain.usecase.login.SetGuestLoginTokenUseCase
import dagger.hilt.android.lifecycle.HiltViewModel
import kotlinx.coroutines.channels.Channel
import kotlinx.coroutines.delay
import kotlinx.coroutines.flow.MutableSharedFlow
import kotlinx.coroutines.flow.MutableStateFlow
import kotlinx.coroutines.flow.SharedFlow
import kotlinx.coroutines.flow.StateFlow
import kotlinx.coroutines.flow.asSharedFlow
import kotlinx.coroutines.flow.asStateFlow
import kotlinx.coroutines.flow.receiveAsFlow
import kotlinx.coroutines.flow.update
import kotlinx.coroutines.launch
import timber.log.Timber
Expand Down Expand Up @@ -54,8 +53,8 @@ class SplashViewModel @Inject constructor(
private val _uiState = MutableStateFlow(SplashUiState())
val uiState: StateFlow<SplashUiState> = _uiState.asStateFlow()

private val _eventFlow = MutableSharedFlow<SplashUiEvent>()
val eventFlow: SharedFlow<SplashUiEvent> = _eventFlow.asSharedFlow()
private val _eventChannel = Channel<SplashUiEvent>()
val eventFlow = _eventChannel.receiveAsFlow()

init {
viewModelScope.launch {
Expand Down Expand Up @@ -138,13 +137,13 @@ class SplashViewModel @Inject constructor(

fun navigateToOnBoarding() {
viewModelScope.launch {
_eventFlow.emit(SplashUiEvent.NavigateToOnBoarding)
_eventChannel.send(SplashUiEvent.NavigateToOnBoarding)
}
}

fun navigateToHome() {
viewModelScope.launch {
_eventFlow.emit(SplashUiEvent.NavigateToHome)
_eventChannel.send(SplashUiEvent.NavigateToHome)
}
}
}