add time ms and txn to encoded json #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new fields to the output JSON to help with tracking and debugging.
time_ms: time in ms of the server time for the record. This was added becausetimeis encoded inRFC3339which drops millisecond precision. For compatibility both fields remain.time_msis encoded as a json number.txn: this is the record's transaction id combined with the nanosecond timestamp of when bifrost saw the transaction from the WAL. This is encoded in a string of<txn id>-<ns timestamp>. The timestamp helps determine if bifrost re-read a transaction.