fix(ci): use the docker login action (#73)

Co-authored-by: Matt Wise <[email protected]>
Nextdoor · Oct 21, 2024 · 20e5ea0 · 20e5ea0
1 parent 331affa
commit 20e5ea0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -12,8 +12,7 @@ jobs:
         id: meta
         uses: docker/metadata-action@v3
         with:
-          images: |
-            docker.pkg.github.com/nextdoor/gogo/gogo
+          images: docker.pkg.github.com/nextdoor/gogo/gogo
           tags: |
             type=ref,event=branch
             type=ref,event=tag
@@ -25,7 +24,5 @@ jobs:
         uses: docker/build-push-action@v6
         with:
           push: false
-          registry: docker.pkg.github.com
-          repository: nextdoor/gogo/gogo
           tags: ${{ steps.meta.outputs.tags }}
           labels: ${{ steps.meta.outputs.labels }}
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -13,12 +13,17 @@ jobs:
       - name: Check out the repo
         uses: actions/checkout@v2
 
+      - name: Login to Docker Hub
+        uses: docker/login-action@v3
+        with:
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+
       - name: Docker meta
         id: meta
         uses: docker/metadata-action@v3
         with:
-          images: |
-            ghcr.io/nextdoor/gogo
+          images: ghcr.io/nextdoor/gogo
           tags: |
             type=ref,event=branch
             type=ref,event=tag
@@ -29,10 +34,6 @@ jobs:
       - name: Push to GitHub Packages
         uses: docker/build-push-action@v6
         with:
-          username: ${{ github.actor }}
-          password: ${{ secrets.GITHUB_TOKEN }}
-          registry: ghcr.io
-          repository: nextdoor/gogo
           push: true
           tags: ${{ steps.meta.outputs.tags }}
           labels: ${{ steps.meta.outputs.labels }}