report error creating cron #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrager02
requested review from
calvin681,
sundargates,
Andyz26,
hmitnflx and
fdc-ntflx
as code owners
dtrager02
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
Uploaded ArtifactsTo use these artifacts in your Gradle project, paste the following lines in your build.gradle. |
Andyz26
reviewed
Dec 16, 2024
| @@ -790,6 +792,10 @@ public void onJobClusterInitialize(JobClusterProto.InitializeJobClusterRequest i | |||
| cronManager = new CronManager(name, getSelf(), jobClusterMetadata.getJobClusterDefinition().getSLA()); | |||
| } catch (Exception e) { | |||
| logger.warn("Exception initializing cron", e); | |||
| getSender().tell(new JobClusterManagerProto.CreateJobClusterResponse( | |||
There was a problem hiding this comment.
maybe separate this catch to known error (SchedulerException) and other error (exception) and use different error code + message.
dtrager02
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
dtrager02
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
dtrager02
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Andyz26
requested a deployment
to
Integrate Pull Request
GitHub Actions
Waiting
Andyz26
reviewed
Jan 15, 2025
| getSender().tell(new JobClusterManagerProto.CreateJobClusterResponse( | ||
| initReq.requestId, e instanceof SchedulerException?CLIENT_ERROR:SERVER_ERROR, | ||
| "Job Cluster " + jobClusterName + " could not be created due to cron initialization error" + e.getMessage(), | ||
| jobClusterName), getSelf()); |
There was a problem hiding this comment.
in this case don't you want to stop here and not initRunning workers?
dtrager02
requested a deployment
to
Integrate Pull Request
GitHub Actions
Waiting
dtrager02
requested a deployment
to
Integrate Pull Request
GitHub Actions
Waiting
Andyz26
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, initializing a job cluster with an incorrect cron schedule that cannot be parsed by Quartz silently errors with a warning log. We should return a response instead
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests