bump spectator library to a more recent version #587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmitnflx
requested review from
nickmahilani,
jeffchao,
piygoyal,
calvin681,
sundargates,
Andyz26,
markcho,
liuml07 and
fdc-ntflx
as code owners
hmitnflx
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
sundargates
approved these changes
Nov 16, 2023
| @@ -17,7 +17,7 @@ ext { | |||
| archaiusVersion = 'latest.release' | |||
| versionMockito = '2.18.+' | |||
| mqlVersion = '3.2.2' | |||
| spectatorVersion = '0.134.0' | |||
There was a problem hiding this comment.
Can we get rid of the version here and instead use ext.libraries in the root build.gradle?
Andyz26
reviewed
Nov 16, 2023
| @@ -17,7 +17,7 @@ ext { | |||
| archaiusVersion = 'latest.release' | |||
| versionMockito = '2.18.+' | |||
| mqlVersion = '3.2.2' | |||
| spectatorVersion = '0.134.0' | |||
| spectatorVersion = '1.6.10' | |||
There was a problem hiding this comment.
just wondering if we need to actually declare spectator as "API" in this module or can it be compileOnly to let application resolve it.
There was a problem hiding this comment.
This would become a breaking change if we do that right? if an application doesn't have explicit dependency on spectator api.
There was a problem hiding this comment.
that's true. I just assume all internal applications have a dependency on spectator already.
hmitnflx
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
Uploaded ArtifactsTo use these artifacts in your Gradle project, paste the following lines in your build.gradle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Explain context and other details for this pull request.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests