Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring ResourceClusterActor class #583

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Refactoring ResourceClusterActor class #583

merged 6 commits into from
Nov 14, 2023

Conversation

sundargates
Copy link
Contributor

@sundargates sundargates commented Nov 10, 2023 •
edited
Loading

Context

  1. Refactored ResourceClusterActor class
  2. Removed unused ResourceClusterTaskExecutorMapper class,
  3. Added request/response logging in ResourceClusterRoute to debug issues.

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable

@sundargates sundargates temporarily deployed to Integrate Pull Request November 10, 2023 15:57 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2023 •
edited
Loading

Test Results

546 tests  ±0   538 ✔️ ±0   7m 25s ⏱️ +27s
129 suites ±0       8 💤 ±0 
129 files   ±0       0 ❌ ±0 

Results for commit cc462b2. ± Comparison against base commit 3f575ed.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2023 •
edited
Loading

Uploaded Artifacts

To use these artifacts in your Gradle project, paste the following lines in your build.gradle.

resolutionStrategy {
    force "io.mantisrx:mantis-common:0.1.0-20231114.003602-439"
    force "io.mantisrx:mantis-client:0.1.0-20231114.003602-440"
    force "io.mantisrx:mantis-discovery-proto:0.1.0-20231114.003602-439"
    force "io.mantisrx:mantis-common-serde:0.1.0-20231114.003602-439"
    force "io.mantisrx:mantis-network:0.1.0-20231114.003602-439"
    force "io.mantisrx:mantis-runtime:0.1.0-20231114.003602-440"
    force "io.mantisrx:mantis-remote-observable:0.1.0-20231114.003602-440"
    force "io.mantisrx:mantis-runtime-loader:0.1.0-20231114.003602-440"
    force "io.mantisrx:mantis-testcontainers:0.1.0-20231114.003602-109"
    force "io.mantisrx:mantis-connector-iceberg:0.1.0-20231114.003602-438"
    force "io.mantisrx:mantis-shaded:0.1.0-20231114.003602-438"
    force "io.mantisrx:mantis-connector-job:0.1.0-20231114.003602-440"
    force "io.mantisrx:mantis-connector-kafka:0.1.0-20231114.003602-440"
    force "io.mantisrx:mantis-control-plane-client:0.1.0-20231114.003602-439"
    force "io.mantisrx:mantis-connector-publish:0.1.0-20231114.003602-439"
    force "io.mantisrx:mantis-control-plane-core:0.1.0-20231114.003602-433"
    force "io.mantisrx:mantis-control-plane-server:0.1.0-20231114.003602-433"
    force "io.mantisrx:mantis-examples-mantis-publish-sample:0.1.0-20231114.003602-433"
    force "io.mantisrx:mantis-examples-groupby-sample:0.1.0-20231114.003602-433"
    force "io.mantisrx:mantis-examples-sine-function:0.1.0-20231114.003602-433"
    force "io.mantisrx:mantis-examples-jobconnector-sample:0.1.0-20231114.003602-433"
    force "io.mantisrx:mantis-examples-synthetic-sourcejob:0.1.0-20231114.003602-433"
    force "io.mantisrx:mantis-examples-twitter-sample:0.1.0-20231114.003602-433"
    force "io.mantisrx:mantis-examples-wordcount:0.1.0-20231114.003602-433"
    force "io.mantisrx:mantis-publish-netty:0.1.0-20231114.003602-432"
    force "io.mantisrx:mantis-publish-core:0.1.0-20231114.003602-433"
    force "io.mantisrx:mantis-server-agent:0.1.0-20231114.003602-433"
    force "io.mantisrx:mantis-examples-core:0.1.0-20231114.003602-433"
    force "io.mantisrx:mantis-server-worker-client:0.1.0-20231114.003602-433"
    force "io.mantisrx:mantis-source-job-kafka:0.1.0-20231114.003602-433"
    force "io.mantisrx:mantis-server-worker:0.1.0-20231114.003602-433"
    force "io.mantisrx:mantis-publish-netty-guice:0.1.0-20231114.003602-433"
    force "io.mantisrx:mantis-source-job-publish:0.1.0-20231114.003602-433"
}

@sundargates sundargates had a problem deploying to Integrate Pull Request November 13, 2023 22:02 — with GitHub Actions Failure
@sundargates sundargates had a problem deploying to Integrate Pull Request November 13, 2023 22:05 — with GitHub Actions Failure
@sundargates sundargates temporarily deployed to Integrate Pull Request November 13, 2023 22:09 — with GitHub Actions Inactive
@sundargates
Adding some more precondition to check what's going on
2d9a0b6
@sundargates
Some minor refactoring and added some additional debugging in Resourc…
4c35700 
…eCluster classes

1. Get rid of class ResourceClusterTaskExecutorMapper as it was not being used
2. Logging all request/response pairs from ResourceClusterRoute to understand the issues going on
@sundargates
Some more debug logs
ec34c0b
@sundargates
Fixing compilation
e2cf90b
@sundargates sundargates temporarily deployed to Integrate Pull Request November 13, 2023 22:53 — with GitHub Actions Inactive
@sundargates sundargates temporarily deployed to Integrate Pull Request November 13, 2023 23:01 — with GitHub Actions Inactive
@sundargates sundargates temporarily deployed to Integrate Pull Request November 14, 2023 00:34 — with GitHub Actions Inactive
@sundargates sundargates changed the title [WIP] Adding some more precondition to check what's going on Adding some more precondition to check what's going on Nov 14, 2023
@sundargates sundargates changed the title Adding some more precondition to check what's going on Refactoring ResourceClusterActor class Nov 14, 2023
@sundargates sundargates merged commit 81bce54 into Netflix:master Nov 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andyz26 Andyz26 Andyz26 approved these changes

@nickmahilani nickmahilani Awaiting requested review from nickmahilani

@jeffchao jeffchao Awaiting requested review from jeffchao

@piygoyal piygoyal Awaiting requested review from piygoyal

@calvin681 calvin681 Awaiting requested review from calvin681 calvin681 is a code owner

@hmitnflx hmitnflx Awaiting requested review from hmitnflx hmitnflx is a code owner

@markcho markcho Awaiting requested review from markcho

@liuml07 liuml07 Awaiting requested review from liuml07

@fdc-ntflx fdc-ntflx Awaiting requested review from fdc-ntflx fdc-ntflx is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sundargates @Andyz26