Use a separate directory to store registration information #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundargates
requested review from
nickmahilani,
jeffchao,
piygoyal,
calvin681,
Andyz26,
hmitnflx,
markcho,
liuml07 and
fdc-ntflx
as code owners
sundargates
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
sundargates
commented
Nov 10, 2023
Comment on lines
+255
to
+259
|
|
||
| @Override | ||
| public File getRegistrationStoreDir() { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
This will not and should not be used by the worker itself. Hence, it returns a null for the time being.
sundargates
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
^^^
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests