Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics for each of the RC Actor messages #576

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

sundargates
Copy link
Contributor

Context

Explain context and other details for this pull request.

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable

Copy link

github-actions bot commented Nov 2, 2023

Test Results

545 tests  ±0   537 ✔️ ±0   6m 27s ⏱️ -27s
128 suites ±0       8 💤 ±0 
128 files   ±0       0 ±0 

Results for commit e24b3dd. ± Comparison against base commit fcfb1e4.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@Andyz26 Andyz26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check/fix the test failure as well?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.match(GetClusterUsageRequest.class,
    req -> sender().tell(this.executorStateManager.getClusterUsage(req), self()))
.match(GetClusterIdleInstancesRequest.class,
    req -> sender().tell(onGetClusterIdleInstancesRequest(req), self()))

These two could be costly and worth checking too.

@sundargates sundargates had a problem deploying to Integrate Pull Request November 2, 2023 22:46 — with GitHub Actions Failure
@sundargates sundargates merged commit 7d098a8 into Netflix:master Nov 2, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants